Bug 1497336: Remove Cranelift Win32 static analysis workaround; r=froydnj
authorBenjamin Bouvier <benj@benj.me>
Thu, 11 Oct 2018 14:52:39 +0000
changeset 440721 bb2685bc742eec021c972c59cf74e564780e307d
parent 440720 c844033d55eb91acb4190ee202361b1b95062e0c
child 440722 f3ada5207c53a7fb05605fd6ce116ff6fa04a69b
push id34832
push usernbeleuzu@mozilla.com
push dateFri, 12 Oct 2018 03:43:40 +0000
treeherdermozilla-central@a19bd92250b6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1497336
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1497336: Remove Cranelift Win32 static analysis workaround; r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D8062
js/moz.configure
--- a/js/moz.configure
+++ b/js/moz.configure
@@ -481,23 +481,18 @@ def enable_build_binast(target, mileston
 
 set_define('JS_BUILD_BINAST', enable_build_binast)
 set_config('JS_BUILD_BINAST', enable_build_binast)
 
 
 # Experimental support for wasm code generation with Cranelift
 # ==============================================================
 
-@depends('--enable-clang-plugin', '--enable-release',
-         debug_rust, target, milestone.is_nightly, when='--enable-compile-environment')
-def default_cranelift(static_analysis, release, debug_rust, target, is_nightly):
-    # LLVM runs out of memory on win32 static analysis optimized builds when
-    # linking gkrust, so do not compile Cranelift there.
-    if static_analysis and target.kernel == 'WINNT' and target.cpu == 'x86' and release and not debug_rust:
-        return False
+@depends(milestone.is_nightly)
+def default_cranelift(is_nightly):
     return is_nightly
 
 js_option('--enable-cranelift',
           default=default_cranelift,
           help='Enable Cranelift code generator for wasm')
 
 set_config('ENABLE_WASM_CRANELIFT', depends_if('--enable-cranelift')(lambda x: True))
 set_define('ENABLE_WASM_CRANELIFT', depends_if('--enable-cranelift')(lambda x: True))