Bug 1595656 - isUserFacingLogin should only exclude the FxA one, not legacy extension ones. r=sfoster
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Thu, 21 Nov 2019 14:41:41 +0000
changeset 503228 bb120dcc1726ee5590bbba188203379c4be4e261
parent 503227 5fe975a91529160a1e9c7b7a15f61e101a0511e6
child 503229 942c83d4c62d147d6de02004cc312fc2540c029d
push id36831
push userapavel@mozilla.com
push dateFri, 22 Nov 2019 09:15:12 +0000
treeherdermozilla-central@80ab213de5a9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssfoster
bugs1595656
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1595656 - isUserFacingLogin should only exclude the FxA one, not legacy extension ones. r=sfoster We shouldn't hide data saved by legacy extensions, the user should remain in control of them since they may contain credentials they want to delete. Differential Revision: https://phabricator.services.mozilla.com/D53833
toolkit/components/passwordmgr/LoginHelper.jsm
--- a/toolkit/components/passwordmgr/LoginHelper.jsm
+++ b/toolkit/components/passwordmgr/LoginHelper.jsm
@@ -1097,17 +1097,17 @@ this.LoginHelper = {
     Services.obs.notifyObservers(
       dataObject,
       "passwordmgr-storage-changed",
       changeType
     );
   },
 
   isUserFacingLogin(login) {
-    return !login.origin.startsWith("chrome://");
+    return login.origin != "chrome://FirefoxAccounts"; // FXA_PWDMGR_HOST
   },
 
   async getAllUserFacingLogins() {
     try {
       let logins = await Services.logins.getAllLoginsAsync();
       return logins.filter(this.isUserFacingLogin);
     } catch (e) {
       if (e.result == Cr.NS_ERROR_ABORT) {