author | Mike Hommey <mh+mozilla@glandium.org> |
Thu, 12 Sep 2013 08:52:36 +0900 | |
changeset 146727 | b9552f5d4476f4f079c80a8ff4f4c8312fe71b3d |
parent 146726 | 3ca22e239a1dbdb25993a49a7bba63ad4143e832 |
child 146728 | 1c9fc8a6e7078ff449aa63be1ab69e514978b804 |
push id | 25270 |
push user | emorley@mozilla.com |
push date | Thu, 12 Sep 2013 11:04:52 +0000 |
treeherder | mozilla-central@b83f6d80af5f [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
bugs | 914482 |
milestone | 26.0a1 |
backs out | 237c3227948158d41d6c6dd3ea2bf915681e352f |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
config/rules.mk | file | annotate | diff | comparison | revisions | |
js/src/config/rules.mk | file | annotate | diff | comparison | revisions |
--- a/config/rules.mk +++ b/config/rules.mk @@ -49,21 +49,21 @@ INCLUDED_RULES_MK = 1 XPIDL_FLAGS \ $(NULL) ifndef EXTERNALLY_MANAGED_MAKE_FILE # Using $(firstword) may not be perfect. But it should be good enough for most # scenarios. _current_makefile = $(CURDIR)/$(firstword $(MAKEFILE_LIST)) -$(foreach var,$(_MOZBUILD_EXTERNAL_VARIABLES),$(if $(filter file override,$(subst $(NULL) ,_,$(origin $(var)))),\ +$(foreach var,$(_MOZBUILD_EXTERNAL_VARIABLES),$(if $($(var)),\ $(error Variable $(var) is defined in $(_current_makefile). It should only be defined in moz.build files),\ )) -$(foreach var,$(_DEPRECATED_VARIABLES),$(if $(filter file override,$(subst $(NULL) ,_,$(origin $(var)))),\ +$(foreach var,$(_DEPRECATED_VARIABLES),$(if $($(var)),\ $(error Variable $(var) is defined in $(_current_makefile). This variable has been deprecated. It does nothing. It must be removed in order to build)\ )) ifneq (,$(XPIDLSRCS)$(SDK_XPIDLSRCS)) $(error XPIDLSRCS and SDK_XPIDLSRCS have been merged and moved to moz.build files as the XPIDL_SOURCES variable. You must move these variables out of $(_current_makefile)) endif # Import the automatically generated backend file. If this file doesn't exist,
--- a/js/src/config/rules.mk +++ b/js/src/config/rules.mk @@ -49,21 +49,21 @@ INCLUDED_RULES_MK = 1 XPIDL_FLAGS \ $(NULL) ifndef EXTERNALLY_MANAGED_MAKE_FILE # Using $(firstword) may not be perfect. But it should be good enough for most # scenarios. _current_makefile = $(CURDIR)/$(firstword $(MAKEFILE_LIST)) -$(foreach var,$(_MOZBUILD_EXTERNAL_VARIABLES),$(if $(filter file override,$(subst $(NULL) ,_,$(origin $(var)))),\ +$(foreach var,$(_MOZBUILD_EXTERNAL_VARIABLES),$(if $($(var)),\ $(error Variable $(var) is defined in $(_current_makefile). It should only be defined in moz.build files),\ )) -$(foreach var,$(_DEPRECATED_VARIABLES),$(if $(filter file override,$(subst $(NULL) ,_,$(origin $(var)))),\ +$(foreach var,$(_DEPRECATED_VARIABLES),$(if $($(var)),\ $(error Variable $(var) is defined in $(_current_makefile). This variable has been deprecated. It does nothing. It must be removed in order to build)\ )) ifneq (,$(XPIDLSRCS)$(SDK_XPIDLSRCS)) $(error XPIDLSRCS and SDK_XPIDLSRCS have been merged and moved to moz.build files as the XPIDL_SOURCES variable. You must move these variables out of $(_current_makefile)) endif # Import the automatically generated backend file. If this file doesn't exist,