Bug 1476640: Fix DEAD_STORE errors in media/mtransport/*.
authorRobert Bartlensky <rbartlensky@mozilla.com>
Fri, 20 Jul 2018 19:16:38 +0300
changeset 427578 b8b952f123c7d0b81965e086a4ac097eba24a563
parent 427577 f50ace088be517079e8032a385b28980c9632bc2
child 427579 f8d04aa5f853750145c9e821eb0f150fb95a721d
push id34307
push usercsabou@mozilla.com
push dateFri, 20 Jul 2018 21:42:49 +0000
treeherdermozilla-central@6eec814dea78 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1476640
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476640: Fix DEAD_STORE errors in media/mtransport/*. Reviewers: ekr Reviewed By: ekr Bug #: 1476640 Differential Revision: https://phabricator.services.mozilla.com/D2265
media/mtransport/nricectx.cpp
--- a/media/mtransport/nricectx.cpp
+++ b/media/mtransport/nricectx.cpp
@@ -41,16 +41,17 @@ THEORY OF LIABILITY, WHETHER IN CONTRACT
 OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
 #include <string>
 #include <vector>
 
 #include "mozilla/Telemetry.h"
 #include "mozilla/UniquePtr.h"
+#include "mozilla/Unused.h"
 
 #include "logging.h"
 #include "nspr.h"
 #include "nss.h"
 #include "pk11pub.h"
 #include "plbase64.h"
 
 #include "nsCOMPtr.h"
@@ -641,26 +642,26 @@ NrIceCtx::Initialize(const std::string& 
   nsresult rv;
   nsCOMPtr<nsIPrefService> pref_service =
     do_GetService(NS_PREFSERVICE_CONTRACTID, &rv);
 
   if (NS_SUCCEEDED(rv)) {
     nsCOMPtr<nsIPrefBranch> pref_branch;
     rv = pref_service->GetBranch(nullptr, getter_AddRefs(pref_branch));
     if (NS_SUCCEEDED(rv)) {
-      rv = pref_branch->GetCharPref(
+      Unused << pref_branch->GetCharPref(
           "media.peerconnection.nat_simulator.mapping_type",
           mapping_type);
-      rv = pref_branch->GetCharPref(
+      Unused << pref_branch->GetCharPref(
           "media.peerconnection.nat_simulator.filtering_type",
           filtering_type);
-      rv = pref_branch->GetBoolPref(
+      Unused << pref_branch->GetBoolPref(
           "media.peerconnection.nat_simulator.block_udp",
           &block_udp);
-      rv = pref_branch->GetBoolPref(
+      Unused << pref_branch->GetBoolPref(
           "media.peerconnection.nat_simulator.block_tcp",
           &block_tcp);
     }
   }
 
   if (!mapping_type.IsEmpty() && !filtering_type.IsEmpty()) {
     MOZ_MTLOG(ML_DEBUG, "NAT filtering type: " << filtering_type.get());
     MOZ_MTLOG(ML_DEBUG, "NAT mapping type: " << mapping_type.get());