author | Ms2ger <ms2ger@gmail.com> |
Sun, 11 Mar 2012 09:51:22 +0100 | |
changeset 88701 | b7caf8586f8f6c0aad71220545f90d1a8aaa77d1 |
parent 88700 | 565fd024595d5169548337a20e2cb8deb1e458ba |
child 88702 | a455e5a0d02b8a3f2f74ce2223b9870b95047d78 |
push id | 22218 |
push user | Ms2ger@gmail.com |
push date | Sun, 11 Mar 2012 08:56:19 +0000 |
treeherder | mozilla-central@c33438bd5706 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | jst |
bugs | 734473 |
milestone | 13.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/content/xul/document/src/nsXULPrototypeDocument.cpp +++ b/content/xul/document/src/nsXULPrototypeDocument.cpp @@ -783,21 +783,17 @@ void nsXULPDGlobalObject::ClearGlobalObjectOwner() { NS_ASSERTION(!mCachedPrincipal, "This shouldn't ever be set until now!"); // Cache mGlobalObjectOwner's principal if possible. if (this != nsXULPrototypeDocument::gSystemGlobal) mCachedPrincipal = mGlobalObjectOwner->DocumentPrincipal(); - if (mContext) { - mContext->FinalizeContext(); - mContext = NULL; - } - + mContext = NULL; mGlobalObjectOwner = NULL; } void nsXULPDGlobalObject::OnFinalize(JSObject* aObject) { mJSObject = NULL;
--- a/dom/base/nsGlobalWindow.cpp +++ b/dom/base/nsGlobalWindow.cpp @@ -2397,17 +2397,16 @@ nsGlobalWindow::SetDocShell(nsIDocShell* // SetArguments(), drop our reference to the arguments. mArguments = nsnull; mArgumentsLast = nsnull; mArgumentsOrigin = nsnull; } if (mContext) { mContext->GC(js::gcreason::SET_DOC_SHELL); - mContext->FinalizeContext(); mContext = nsnull; } #ifdef DEBUG nsCycleCollector_DEBUG_shouldBeFreed(mContext); nsCycleCollector_DEBUG_shouldBeFreed(static_cast<nsIScriptGlobalObject*>(this)); #endif }
--- a/dom/base/nsIScriptContext.h +++ b/dom/base/nsIScriptContext.h @@ -71,18 +71,18 @@ public: virtual nsIScriptObjectPrincipal* GetObjectPrincipal() = 0; }; NS_DEFINE_STATIC_IID_ACCESSOR(nsIScriptContextPrincipal, NS_ISCRIPTCONTEXTPRINCIPAL_IID) #define NS_ISCRIPTCONTEXT_IID \ -{ 0x6a536a37, 0x9773, 0x467e, \ - { 0x93, 0xb2, 0xdb, 0xe6, 0xe6, 0xec, 0x24, 0xc3 } } +{ 0xdfaea249, 0xaaad, 0x48bd, \ + { 0xb8, 0x04, 0x92, 0xad, 0x30, 0x88, 0xd0, 0xc6 } } /* This MUST match JSVERSION_DEFAULT. This version stuff if we don't know what language we have is a little silly... */ #define SCRIPTVERSION_DEFAULT JSVERSION_DEFAULT /** * It is used by the application to initialize a runtime and run scripts. * A script runtime would implement this interface. @@ -341,21 +341,16 @@ public: * reentrancy issues during the initialization process. * * @return true if initialized, false if not * */ virtual bool IsContextInitialized() = 0; /** - * Called as the global object discards its reference to the context. - */ - virtual void FinalizeContext() = 0; - - /** * For garbage collected systems, do a synchronous collection pass. * May be a no-op on other systems * * @return NS_OK if the method is successful */ virtual void GC(js::gcreason::Reason aReason) = 0; /**
--- a/dom/base/nsJSEnvironment.cpp +++ b/dom/base/nsJSEnvironment.cpp @@ -2969,22 +2969,16 @@ nsJSContext::DidInitializeContext() bool nsJSContext::IsContextInitialized() { return mIsInitialized; } void -nsJSContext::FinalizeContext() -{ - ; -} - -void nsJSContext::ScriptEvaluated(bool aTerminated) { if (aTerminated && mTerminations) { // Make sure to null out mTerminations before doing anything that // might cause new termination funcs to be added! nsJSContext::TerminationFuncClosure* start = mTerminations; mTerminations = nsnull;
--- a/dom/base/nsJSEnvironment.h +++ b/dom/base/nsJSEnvironment.h @@ -138,17 +138,16 @@ public: virtual nsresult ConnectToInner(nsIScriptGlobalObject *aNewInner, JSObject *aOuterGlobal); virtual nsresult InitContext(); virtual nsresult CreateOuterObject(nsIScriptGlobalObject *aGlobalObject, nsIScriptGlobalObject *aCurrentInner); virtual nsresult SetOuterObject(JSObject* aOuterObject); virtual nsresult InitOuterWindow(); virtual bool IsContextInitialized(); - virtual void FinalizeContext(); virtual void ScriptEvaluated(bool aTerminated); virtual void SetTerminationFunction(nsScriptTerminationFunc aFunc, nsIDOMWindow* aRef); virtual bool GetScriptsEnabled(); virtual void SetScriptsEnabled(bool aEnabled, bool aFireTimeouts); virtual nsresult SetProperty(JSObject* aTarget, const char* aPropName, nsISupports* aVal);