Bug 1552328 - Add missing unregisterListener in GeckoViewProgress. r=droeh
authorAgi Sferro <agi@sferro.dev>
Fri, 17 May 2019 13:43:44 +0000
changeset 474332 b63f61a97f1776a0909655817e6391cfcfe09324
parent 474331 00afc705d4eef04a1d71cea44953d0ba232a3794
child 474333 566c25b14d477ff86772ed8bb270d64609f5a3dc
push id36030
push userrgurzau@mozilla.com
push dateFri, 17 May 2019 21:41:01 +0000
treeherdermozilla-central@7c540586aedb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdroeh
bugs1552328
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1552328 - Add missing unregisterListener in GeckoViewProgress. r=droeh Differential Revision: https://phabricator.services.mozilla.com/D31538
mobile/android/modules/geckoview/GeckoViewProgress.jsm
--- a/mobile/android/modules/geckoview/GeckoViewProgress.jsm
+++ b/mobile/android/modules/geckoview/GeckoViewProgress.jsm
@@ -164,16 +164,17 @@ class GeckoViewProgress extends GeckoVie
     debug `onDisable`;
 
     if (this.progressFilter) {
       this.progressFilter.removeProgressListener(this);
       this.browser.removeProgressListener(this.progressFilter);
     }
 
     Services.obs.removeObserver(this, "oop-frameloader-crashed");
+    this.unregisterListener("GeckoView:FlushSessionState");
   }
 
   onEvent(aEvent, aData, aCallback) {
     debug `onEvent: event=${aEvent}, data=${aData}`;
 
     switch (aEvent) {
       case "GeckoView:FlushSessionState":
         this.messageManager.sendAsyncMessage("GeckoView:FlushSessionState");