Bug 1455143 - Don't remove common test archive; r=ted
authorGregory Szorc <gps@mozilla.com>
Wed, 18 Apr 2018 17:34:25 -0700
changeset 414626 b604acdb1c78b9f3789feb36fa3edcbce2d09748
parent 414625 12cfbcd2ccf467c79bb614e3b99cf4a677ff95a6
child 414627 7f69dd1ba3cb669fdbc7db301870009087ab0639
push id33874
push userrgurzau@mozilla.com
push dateFri, 20 Apr 2018 09:11:15 +0000
treeherdermozilla-central@cc0d7de218cb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1455143
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1455143 - Don't remove common test archive; r=ted This target is a prereq for all test archives. Why we only remove a single test archive, I don't know. We always build this test archive. So it should always get overwritten and we don't need to remove an existing file. MozReview-Commit-ID: 1qd1T3w6kVT
testing/testsuite-targets.mk
--- a/testing/testsuite-targets.mk
+++ b/testing/testsuite-targets.mk
@@ -139,17 +139,16 @@ test-packages-manifest:
 	$(PYTHON) $(topsrcdir)/build/gen_test_packages_manifest.py \
       --jsshell $(JSSHELL_NAME) \
       --dest-file '$(MOZ_TEST_PACKAGES_FILE)' \
       $(call PKG_ARG,common,zip) \
       $(foreach pkg,$(TEST_PKGS_ZIP),$(call PKG_ARG,$(pkg),zip)) \
       $(foreach pkg,$(TEST_PKGS_TARGZ),$(call PKG_ARG,$(pkg),tar.gz))
 
 package-tests-prepare-dest:
-	@rm -f '$(DIST)/$(PKG_PATH)$(TEST_PACKAGE)'
 	$(NSINSTALL) -D $(DIST)/$(PKG_PATH)
 
 define package_archive
 package-tests-$(1): stage-all package-tests-prepare-dest
 	$$(call py_action,test_archive, \
 		$(1) \
 		'$$(abspath $$(DIST))/$$(PKG_PATH)/$$(PKG_BASENAME).$(1).tests.$(2)')
 package-tests: package-tests-$(1)