Bug 782779 - Using simple quotes for GroupItem's placeholder breaks some localized strings; r=ttaubert
authorPascal Chevrel <pascalc@gmail.com>
Wed, 26 Sep 2012 16:25:20 +0200
changeset 108199 b56fa836e894675118171680ab693f69f6fc7180
parent 108198 e889440ba18db5ab35f8b08d6c92ccc758ac6e5d
child 108200 b038e9e2023f712021f36ff1a706fc106fb7a2af
push id23544
push userttaubert@mozilla.com
push dateThu, 27 Sep 2012 07:12:21 +0000
treeherdermozilla-central@b038e9e2023f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersttaubert
bugs782779
milestone18.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 782779 - Using simple quotes for GroupItem's placeholder breaks some localized strings; r=ttaubert
browser/components/tabview/groupitems.js
--- a/browser/components/tabview/groupitems.js
+++ b/browser/components/tabview/groupitems.js
@@ -88,17 +88,17 @@ function GroupItem(listOfEls, options) {
   this.$resizer = iQ("<div>")
     .addClass('resizer')
     .appendTo($container)
     .hide();
 
   // ___ Titlebar
   var html =
     "<div class='title-container'>" +
-      "<input class='name' placeholder='" + this.defaultName + "'/>" +
+      "<input class='name' />" +
       "<div class='title-shield' />" +
     "</div>";
 
   this.$titlebar = iQ('<div>')
     .addClass('titlebar')
     .html(html)
     .appendTo($container);
 
@@ -107,17 +107,17 @@ function GroupItem(listOfEls, options) {
     .click(function() {
       self.closeAll();
     })
     .attr("title", tabviewString("groupItem.closeGroup"))
     .appendTo($container);
 
   // ___ Title
   this.$titleContainer = iQ('.title-container', this.$titlebar);
-  this.$title = iQ('.name', this.$titlebar);
+  this.$title = iQ('.name', this.$titlebar).attr('placeholder', this.defaultName);
   this.$titleShield = iQ('.title-shield', this.$titlebar);
   this.setTitle(options.title);
 
   var handleKeyPress = function (e) {
     if (e.keyCode == KeyEvent.DOM_VK_ESCAPE ||
         e.keyCode == KeyEvent.DOM_VK_RETURN ||
         e.keyCode == KeyEvent.DOM_VK_ENTER) {
       (self.$title)[0].blur();