Backed out 3 changesets (bug 1503681) for geckoview failures on org.mozilla.geckoview.test.GeckoSessionTestRuleTest.waitForChromeJS. CLOSED TREE
authorBrindusan Cristian <cbrindusan@mozilla.com>
Wed, 28 Nov 2018 11:10:48 +0200
changeset 448497 b526d511169a3ba8ea647d6de9183a62df0da1c8
parent 448496 8fc810b6e52834f8e87aa1118b56ade43e26d7ba
child 448498 3451e101fd67496305b366e5d60744317a60a54f
push id35118
push userccoroiu@mozilla.com
push dateWed, 28 Nov 2018 21:49:40 +0000
treeherdermozilla-central@f2915d3ee5f8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1503681
milestone65.0a1
backs out211c7dfdc4083e48ef9f86a91d219e22fe7f72b7
076cc5bece1d8b9fd86b6fcc3ab7685fa842f854
7a19fe6be68ce356cf2d94b09ad458d8c517bdcf
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 3 changesets (bug 1503681) for geckoview failures on org.mozilla.geckoview.test.GeckoSessionTestRuleTest.waitForChromeJS. CLOSED TREE Backed out changeset 211c7dfdc408 (bug 1503681) Backed out changeset 076cc5bece1d (bug 1503681) Backed out changeset 7a19fe6be68c (bug 1503681)
accessible/tests/mochitest/actions/test_anchors.html
accessible/tests/mochitest/actions/test_aria.html
accessible/tests/mochitest/actions/test_controls.html
accessible/tests/mochitest/actions/test_general.html
accessible/tests/mochitest/actions/test_general.xul
accessible/tests/mochitest/actions/test_keys.html
accessible/tests/mochitest/actions/test_keys_menu.xul
accessible/tests/mochitest/actions/test_link.html
accessible/tests/mochitest/actions/test_media.html
accessible/tests/mochitest/actions/test_select.html
accessible/tests/mochitest/actions/test_tree.xul
accessible/tests/mochitest/actions/test_treegrid.xul
browser/base/content/test/general/browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js
browser/components/extensions/test/browser/webNav_createdTargetSource.html
browser/components/extensions/test/browser/webNav_createdTargetSource_subframe.html
docshell/base/nsDocShell.cpp
dom/base/test/test_bug666604.html
dom/html/test/browser.ini
dom/html/test/browser_targetBlankNoOpener.js
dom/html/test/empty.html
dom/html/test/file_bug1108547-3.html
dom/html/test/file_fullscreen-newtab.html
dom/html/test/file_iframe_sandbox_c_if4.html
dom/html/test/file_iframe_sandbox_h_if1.html
dom/html/test/file_iframe_sandbox_k_if1.html
dom/html/test/file_iframe_sandbox_k_if4.html
dom/html/test/file_iframe_sandbox_k_if8.html
dom/html/test/file_window_open_close_outer.html
dom/html/test/image_yellow.png
dom/security/test/mixedcontentblocker/file_frameNavigation_blankTarget.html
dom/tests/browser/test_noopener_source.html
dom/tests/mochitest/bugs/test_bug458091.html
modules/libpref/init/StaticPrefList.h
testing/web-platform/meta/FileAPI/url/__dir__.ini
testing/web-platform/meta/content-security-policy/unsafe-hashes/__dir__.ini
testing/web-platform/meta/html/browsers/windows/auxiliary-browsing-contexts/__dir__.ini
testing/web-platform/meta/html/semantics/embedded-content/the-iframe-element/__dir__.ini
testing/web-platform/meta/html/semantics/links/links-created-by-a-and-area-elements/__dir__.ini
testing/web-platform/tests/html/semantics/links/links-created-by-a-and-area-elements/support/target_blank_iplicit_noopener.html
testing/web-platform/tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.tentative.html
toolkit/components/extensions/test/mochitest/head_webrequest.js
toolkit/components/extensions/test/mochitest/test_ext_new_tab_processType.html
uriloader/exthandler/tests/mochitest/download_page.html
--- a/accessible/tests/mochitest/actions/test_anchors.html
+++ b/accessible/tests/mochitest/actions/test_anchors.html
@@ -71,27 +71,27 @@
 
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(doTest);
   </script>
 </head>
 
 <body>
 
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=506389"
      title="Some same page links do not fire EVENT_SYSTEM_SCROLLINGSTART">
     Mozilla Bug 506389
   </a><br>
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=437607"
      title="Clicking the 'Skip to main content' link once works, second time fails to initiate a V cursor jump">
     Mozilla Bug 437607
   </a><br>
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=519303"
      title="Same page links to targets with content fires scrolling start accessible event on leaf text node">
     Mozilla Bug 519303
   </a>
 
   <p id="display"></p>
   <div id="content" style="display: none"></div>
   <pre id="test">
--- a/accessible/tests/mochitest/actions/test_aria.html
+++ b/accessible/tests/mochitest/actions/test_aria.html
@@ -130,17 +130,17 @@
 
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(doTest);
   </script>
 </head>
 
 <body>
 
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=410765"
      title="nsIAccessible actions testing">
     Mozilla Bug 410765
   </a>
   <p id="display"></p>
   <div id="content" style="display: none"></div>
   <pre id="test">
   </pre>
--- a/accessible/tests/mochitest/actions/test_controls.html
+++ b/accessible/tests/mochitest/actions/test_controls.html
@@ -72,17 +72,17 @@
 
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(doTest);
   </script>
 </head>
 
 <body>
 
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=477975"
      title="nsIAccessible actions testing">
     Mozilla Bug 477975
   </a>
   <p id="display"></p>
   <div id="content" style="display: none"></div>
   <pre id="test">
   </pre>
--- a/accessible/tests/mochitest/actions/test_general.html
+++ b/accessible/tests/mochitest/actions/test_general.html
@@ -58,27 +58,27 @@
 
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(doTest);
   </script>
 </head>
 
 <body>
 
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=523789"
      title="nsHTMLLiAccessible shouldn't be inherited from linkable accessible">
     Mozilla Bug 523789
   </a><br>
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=423409"
      title="Expose click action if mouseup and mousedown are registered">
     Mozilla Bug 423409
   </a>
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=659620"
      title="hang when trying to edit a page on wikimo with NVDA running">
     Mozilla Bug 659620
   </a>
   <p id="display"></p>
   <div id="content" style="display: none"></div>
   <pre id="test">
   </pre>
--- a/accessible/tests/mochitest/actions/test_general.xul
+++ b/accessible/tests/mochitest/actions/test_general.xul
@@ -87,22 +87,22 @@
 
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(doTest);
   ]]>
   </script>
 
   <hbox flex="1" style="overflow: auto;">
     <body xmlns="http://www.w3.org/1999/xhtml">
-      <a target="_blank" rel="opener"
+      <a target="_blank"
          href="https://bugzilla.mozilla.org/show_bug.cgi?id=410765"
          title="nsIAccessible actions testing">
         Mozilla Bug 410765
       </a>
-      <a target="_blank" rel="opener"
+      <a target="_blank"
          href="https://bugzilla.mozilla.org/show_bug.cgi?id=504252"
          title="Expose STATE_HASPOPUP on XUL elements that have an @popup attribute">
         Mozilla Bug 504252
       </a><br/>
       <p id="display"></p>
       <div id="content" style="display: none">
       </div>
       <pre id="test">
--- a/accessible/tests/mochitest/actions/test_keys.html
+++ b/accessible/tests/mochitest/actions/test_keys.html
@@ -33,17 +33,17 @@
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(doTest);
   </script>
 
 </head>
 
 <body>
 
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=381599"
      title="Inverse relations cache">
     Mozilla Bug 381599
   </a>
   <p id="display"></p>
   <div id="content" style="display: none"></div>
   <pre id="test">
   </pre>
--- a/accessible/tests/mochitest/actions/test_keys_menu.xul
+++ b/accessible/tests/mochitest/actions/test_keys_menu.xul
@@ -61,17 +61,17 @@
 
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(doTest);
   ]]>
   </script>
 
   <hbox flex="1" style="overflow: auto;">
     <body xmlns="http://www.w3.org/1999/xhtml">
-      <a target="_blank" rel="opener"
+      <a target="_blank"
          href="https://bugzilla.mozilla.org/show_bug.cgi?id=672092"
          title="Reorganize access key and keyboard shortcut handling code">
         Mozilla Bug 672092
       </a><br/>
       <p id="display"></p>
       <div id="content" style="display: none">
       </div>
       <pre id="test">
--- a/accessible/tests/mochitest/actions/test_link.html
+++ b/accessible/tests/mochitest/actions/test_link.html
@@ -111,27 +111,27 @@
 
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(doTest);
   </script>
 </head>
 
 <body>
 
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=423409"
      title="Expose click action if mouseup and mousedown are registered">
     Mozilla Bug 423409
   </a>
   <p id="display"></p>
   <div id="content" style="display: none"></div>
   <pre id="test">
   </pre>
 
-  <a href="about:mozilla" id="link1" target="_blank" rel="opener">
+  <a href="about:mozilla" id="link1" target="_blank">
     <img src="../moz.png" id="img1">
   </a>
   <a id="link2" onmousedown="">
     <img src="../moz.png" id="img2">
   </a>
   <a id="link3" onclick="">
     <img src="../moz.png" id="img3">
   </a>
--- a/accessible/tests/mochitest/actions/test_media.html
+++ b/accessible/tests/mochitest/actions/test_media.html
@@ -111,17 +111,17 @@ https://bugzilla.mozilla.org/show_bug.cg
     }
 
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(loadAudioSource);
   </script>
 </head>
 <body>
 
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      title="Expose HTML5 video and audio elements' embedded controls through accessibility APIs"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=483573">Mozilla Bug 483573</a>
   <p id="display"></p>
   <div id="content" style="display: none"></div>
   <pre id="test">
   </pre>
 
   <audio id="audio" controls="true"></audio>
--- a/accessible/tests/mochitest/actions/test_select.html
+++ b/accessible/tests/mochitest/actions/test_select.html
@@ -76,17 +76,17 @@
 
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(doTest);
   </script>
 </head>
 
 <body>
 
-  <a target="_blank" rel="opener"
+  <a target="_blank"
      href="https://bugzilla.mozilla.org/show_bug.cgi?id=673958"
      title="Rework accessible focus handling">
     Mozilla Bug 673958
   </a>
   <p id="display"></p>
   <div id="content" style="display: none"></div>
   <pre id="test">
   </pre>
--- a/accessible/tests/mochitest/actions/test_tree.xul
+++ b/accessible/tests/mochitest/actions/test_tree.xul
@@ -95,17 +95,17 @@
 
     SimpleTest.waitForExplicitFinish();
     addA11yXULTreeLoadEvent(doTest, "tree", new nsTreeTreeView());
   ]]>
   </script>
 
   <hbox flex="1" style="overflow: auto;">
     <body xmlns="http://www.w3.org/1999/xhtml">
-      <a target="_blank" rel="opener"
+      <a target="_blank"
          href="https://bugzilla.mozilla.org/show_bug.cgi?id=503727"
          title="Reorganize implementation of XUL tree accessibility">
         Mozilla Bug 503727
       </a><br/>
       <p id="display"></p>
       <div id="content" style="display: none">
       </div>
       <pre id="test">
--- a/accessible/tests/mochitest/actions/test_treegrid.xul
+++ b/accessible/tests/mochitest/actions/test_treegrid.xul
@@ -160,17 +160,17 @@
 
     SimpleTest.waitForExplicitFinish();
     addA11yLoadEvent(doTest);
   ]]>
   </script>
 
   <hbox flex="1" style="overflow: auto;">
     <body xmlns="http://www.w3.org/1999/xhtml">
-      <a target="_blank" rel="opener"
+      <a target="_blank"
          href="https://bugzilla.mozilla.org/show_bug.cgi?id=503727"
          title="Reorganize implementation of XUL tree accessibility">
         Mozilla Bug 503727
       </a><br/>
       <p id="display"></p>
       <div id="content" style="display: none">
       </div>
       <pre id="test">
--- a/browser/base/content/test/general/browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js
+++ b/browser/base/content/test/general/browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js
@@ -6,17 +6,17 @@ const OPEN_LOCATION_PREF = "browser.link
 const NON_REMOTE_PAGE = "about:welcomeback";
 
 ChromeUtils.import("resource://gre/modules/PrivateBrowsingUtils.jsm");
 
 requestLongerTimeout(2);
 
 function frame_script() {
   content.document.body.innerHTML = `
-    <a href="http://example.com/" target="_blank" rel="opener" id="testAnchor">Open a window</a>
+    <a href="http://example.com/" target="_blank" id="testAnchor">Open a window</a>
   `;
 
   let element = content.document.getElementById("testAnchor");
   element.click();
 }
 
 /**
  * Takes some browser in some window, and forces that browser
--- a/browser/components/extensions/test/browser/webNav_createdTargetSource.html
+++ b/browser/components/extensions/test/browser/webNav_createdTargetSource.html
@@ -28,17 +28,17 @@
         <a id="test-create-new-window-from-mouse-click"
            href="webNav_createdTarget.html#new-window-from-mouse-click">
           Open a target page in a new window from mouse click
         </a>
       </li>
       <li>
         <a id="test-create-new-tab-from-targetblank-click"
            href="webNav_createdTarget.html#new-tab-from-targetblank-click"
-           target="_blank" rel="opener">
+           target="_blank">
           Open a target page in a new tab from click to link with target="_blank"
         </a>
       </li>
     </ul>
 
     <iframe src="webNav_createdTargetSource_subframe.html" style="width: 100%; height: 100%;">
     </iframe>
   </body>
--- a/browser/components/extensions/test/browser/webNav_createdTargetSource_subframe.html
+++ b/browser/components/extensions/test/browser/webNav_createdTargetSource_subframe.html
@@ -28,15 +28,15 @@
         <a id="test-create-new-window-from-mouse-click-subframe"
            href="webNav_createdTarget.html#new-window-from-mouse-click-subframe">
           Open a target page in a new window from mouse click (subframe)
         </a>
       </li>
       <li>
         <a id="test-create-new-tab-from-targetblank-click-subframe"
            href="webNav_createdTarget.html#new-tab-from-targetblank-click-subframe"
-           target="_blank" rel="opener">
+           target="_blank">
           Open a target page in a new tab from click to link with target="_blank"
         </a>
       </li>
     </ul>
   </body>
 </html>
--- a/docshell/base/nsDocShell.cpp
+++ b/docshell/base/nsDocShell.cpp
@@ -13276,53 +13276,28 @@ nsDocShell::OnLinkClickSync(nsIContent* 
   }
 
   uint32_t flags = INTERNAL_LOAD_FLAGS_NONE;
   if (IsElementAnchorOrArea(aContent)) {
     MOZ_ASSERT(aContent->IsHTMLElement());
     nsAutoString referrer;
     aContent->AsElement()->GetAttr(kNameSpaceID_None, nsGkAtoms::rel, referrer);
     nsWhitespaceTokenizerTemplate<nsContentUtils::IsHTMLWhitespace> tok(referrer);
-
-    bool targetBlank = aTargetSpec.LowerCaseEqualsLiteral("_blank");
-    bool explicitOpenerSet = false;
-
-    // The opener behaviour follows a hierarchy, such that if a higher priority
-    // behaviour is specified, it always takes priority. That priority is
-    // currently: norefrerer > noopener > opener > default
-
     while (tok.hasMoreTokens()) {
       const nsAString& token = tok.nextToken();
       if (token.LowerCaseEqualsLiteral("noreferrer")) {
         flags |= INTERNAL_LOAD_FLAGS_DONT_SEND_REFERRER |
                  INTERNAL_LOAD_FLAGS_NO_OPENER;
-        // noreferrer cannot be overwritten by a 'rel=opener'.
-        explicitOpenerSet = true;
+        // We now have all the flags we could possibly have, so just stop.
         break;
       }
-
       if (token.LowerCaseEqualsLiteral("noopener")) {
         flags |= INTERNAL_LOAD_FLAGS_NO_OPENER;
-        explicitOpenerSet = true;
-      }
-
-      if (targetBlank &&
-          StaticPrefs::dom_targetBlankNoOpener_enabled() &&
-          token.LowerCaseEqualsLiteral("opener") &&
-          !explicitOpenerSet) {
-        explicitOpenerSet = true;
-      }
-    }
-
-    if (targetBlank &&
-        StaticPrefs::dom_targetBlankNoOpener_enabled() &&
-        !explicitOpenerSet) {
-      flags |= INTERNAL_LOAD_FLAGS_NO_OPENER;
-    }
-
+      }
+    }
     if (aNoOpenerImplied) {
       flags |= INTERNAL_LOAD_FLAGS_NO_OPENER;
     }
   }
 
   // Get the owner document of the link that was clicked, this will be
   // the document that the link is in, or the last document that the
   // link was in. From that document, we'll get the URI to use as the
--- a/dom/base/test/test_bug666604.html
+++ b/dom/base/test/test_bug666604.html
@@ -111,29 +111,27 @@ function test6() {
       SpecialPowers.pushPrefEnv({"set":[["dom.disable_open_during_load", false]]}, test7);
     }
   dispatchDOMActivate(testlink);
 }
 
 function test7() {
   testlink.href = "javascript:opener.activationListener(); window.close();";
   testlink.target = "_blank";
-  testlink.rel = "opener";
   activationListener =
     function() {
       ok(true, "Click() should activate a link");
       SpecialPowers.pushPrefEnv({"set":[["dom.disable_open_during_load", true]]}, test8);
     }
   testlink.click();
 }
 
 function test8() {
   testlink.href = "javascript:opener.activationListener(); window.close();";
   testlink.target = "_blank";
-  testlink.rel = "opener";
   activationListener =
     function() {
       ok(false, "Click() should not activate a link");
     }
   testlink.click();
   SimpleTest.executeSoon(SimpleTest.finish);
 }
 addLoadEvent(test1);
--- a/dom/html/test/browser.ini
+++ b/dom/html/test/browser.ini
@@ -32,12 +32,8 @@ tags = fullscreen
 [browser_fullscreen-newtab.js]
 tags = fullscreen
 support-files = file_fullscreen-newtab.html
 skip-if = os == 'mac' # bug 1494843
 [browser_submission_flush.js]
 [browser_refresh_wyciwyg_url.js]
 support-files =
   file_refresh_wyciwyg_url.html
-[browser_targetBlankNoOpener.js]
-support-files =
-  empty.html
-  image_yellow.png
deleted file mode 100644
--- a/dom/html/test/browser_targetBlankNoOpener.js
+++ /dev/null
@@ -1,83 +0,0 @@
-const TEST_URL = "http://mochi.test:8888/browser/dom/html/test/empty.html";
-
-async function checkOpener(browser, elm, name, rel) {
-  let p = BrowserTestUtils.waitForNewTab(gBrowser, null, true, true);
-
-  await ContentTask.spawn(browser, {url: TEST_URL, name, rel, elm }, async obj => {
-    let element;
-
-    if (obj.elm == "anchor") {
-      element = content.document.createElement("a");
-      content.document.body.appendChild(element);
-      element.appendChild(content.document.createTextNode(obj.name));
-    } else {
-      let img = content.document.createElement('img');
-      img.src = "image_yellow.png";
-      content.document.body.appendChild(img);
-
-      element = content.document.createElement("area");
-      img.appendChild(element);
-
-      element.setAttribute("shape", "rect");
-      element.setAttribute("coords", "0,0,100,100");
-    }
-
-    element.setAttribute("target", "_blank");
-    element.setAttribute("href", obj.url);
-
-    if (obj.rel) {
-      element.setAttribute("rel", obj.rel);
-    }
-
-    element.click();
-  });
-
-  let newTab = await p;
-  let newBrowser = gBrowser.getBrowserForTab(newTab);
-
-  let hasOpener = await ContentTask.spawn(newTab.linkedBrowser, null, _ => !!content.window.opener);
-
-  BrowserTestUtils.removeTab(newTab);
-  return hasOpener;
-}
-
-async function runTests(browser, elm) {
-  info("Creating an " + elm + " with target=_blank rel=opener");
-  ok(!!(await checkOpener(browser, elm, "rel=opener", "opener")), "We want the opener with rel=opener");
-
-  info("Creating an " + elm + " with target=_blank rel=noopener");
-  ok(!(await checkOpener(browser, elm, "rel=noopener", "noopener")), "We don't want the opener with rel=noopener");
-
-  info("Creating an " + elm + " with target=_blank");
-  ok(!(await checkOpener(browser, elm, "no rel", null)), "We don't want the opener with no rel is passed");
-
-  info("Creating an " + elm + " with target=_blank rel='noopener opener'");
-  ok(!(await checkOpener(browser, elm, "rel=noopener+opener", "noopener opener")), "noopener wins with rel=noopener+opener");
-
-  info("Creating an " + elm + " with target=_blank rel='noreferrer opener'");
-  ok(!(await checkOpener(browser, elm, "noreferrer wins", "noreferrer opener")), "We don't want the opener with rel=noreferrer+opener");
-
-  info("Creating an " + elm + " with target=_blank rel='opener noreferrer'");
-  ok(!(await checkOpener(browser, elm, "noreferrer wins again", "noreferrer opener")), "We don't want the opener with rel=opener+noreferrer");
-}
-
-add_task(async _ => {
-  await SpecialPowers.flushPrefEnv();
-  await SpecialPowers.pushPrefEnv({"set": [
-    ["dom.block_multiple_popups", false],
-    ["dom.disable_open_during_load", true],
-    ["dom.targetBlankNoOpener.enabled", true],
-  ]});
-
-  let tab = BrowserTestUtils.addTab(gBrowser, TEST_URL);
-  gBrowser.selectedTab = tab;
-
-  let browser = gBrowser.getBrowserForTab(tab);
-  await BrowserTestUtils.browserLoaded(browser);
-
-  await runTests(browser, 'anchor');
-  await runTests(browser, 'area');
-
-  info("Removing the tab");
-  BrowserTestUtils.removeTab(tab);
-});
deleted file mode 100644
--- a/dom/html/test/empty.html
+++ /dev/null
@@ -1,1 +0,0 @@
-<html><body></body></html>
--- a/dom/html/test/file_bug1108547-3.html
+++ b/dom/html/test/file_bug1108547-3.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
 <body onload="document.querySelector('a').click();">
-<a href="javascript:opener.document.getElementById('result').textContent = document.cookie;" target="_blank" rel="opener">test</a>
+<a href="javascript:opener.document.getElementById('result').textContent = document.cookie;" target="_blank">test</a>
 <div id="result">not tested yet</div>
 </body>
--- a/dom/html/test/file_fullscreen-newtab.html
+++ b/dom/html/test/file_fullscreen-newtab.html
@@ -1,4 +1,4 @@
 <!DOCTYPE html>
 <meta charset="UTF-8">
-<a id="link" href="about:blank" target="_blank" rel="opener"
+<a id="link" href="about:blank" target="_blank"
    onclick="document.body.requestFullscreen()">Click here</a>
--- a/dom/html/test/file_iframe_sandbox_c_if4.html
+++ b/dom/html/test/file_iframe_sandbox_c_if4.html
@@ -25,12 +25,12 @@
     }
 
     ok(threw, "window.open threw a JS exception and was not allowed");
   }
 </script>
 <body onLoad="doStuff()">
   I am sandboxed but with "allow-scripts allow-same-origin"
 
-  <a href="file_iframe_sandbox_open_window_fail.html" target="_blank" id="target_blank" rel="opener">open window</a>
+  <a href="file_iframe_sandbox_open_window_fail.html" target="_blank" id="target_blank">open window</a>
   <a href="file_iframe_sandbox_open_window_fail.html" target="BC341604" id="target_BC341604">open window</a>
 </body>
 </html>
--- a/dom/html/test/file_iframe_sandbox_h_if1.html
+++ b/dom/html/test/file_iframe_sandbox_h_if1.html
@@ -23,12 +23,12 @@
     } catch(e) {
       ok(false, "Test 3: iframes sandboxed with allow-popups, should be able to open windows");
     }
   }
 </script>
 <body onLoad="doStuff()">
   I am sandboxed but with "allow-popups allow-scripts allow-same-origin"
 
-  <a href="file_iframe_sandbox_open_window_pass.html" target="_blank" rel="opener" id="target_blank">open window</a>
+  <a href="file_iframe_sandbox_open_window_pass.html" target="_blank" id="target_blank">open window</a>
   <a href="file_iframe_sandbox_open_window_pass.html?BC766282" target="BC766282" id="target_BC766282">open window</a>
 </body>
 </html>
--- a/dom/html/test/file_iframe_sandbox_k_if1.html
+++ b/dom/html/test/file_iframe_sandbox_k_if1.html
@@ -36,12 +36,12 @@
     windowsToClose.push(window.open("file_iframe_sandbox_k_if2.html"));
   }
 </script>
 <body onLoad="doStuff()">
   I am navigated to from file_iframe_sandbox_k_if8.html.
   This was opened in an iframe with "allow-scripts allow-popups allow-same-origin".
   However allow-same-origin was removed from the iframe before navigating to me,
   so I should only have "allow-scripts allow-popups" in force.
-  <a href="file_iframe_sandbox_k_if2.html" target="_blank" id="target_blank_if2" rel="opener">open window</a>
+  <a href="file_iframe_sandbox_k_if2.html" target="_blank" id="target_blank_if2">open window</a>
   <a href="file_iframe_sandbox_k_if2.html" target="BC766282_if2" id="target_BC766282_if2">open window</a>
 </body>
 </html>
--- a/dom/html/test/file_iframe_sandbox_k_if4.html
+++ b/dom/html/test/file_iframe_sandbox_k_if4.html
@@ -20,15 +20,15 @@
     sendMouseEvent({type:'click'}, 'target_BC766282_if7');
 
     window.open("file_iframe_sandbox_k_if7.html");
   }
 </script>
 
 <body onLoad="doStuff()">
   I am sandboxed with "allow-scripts allow-popups allow-same-origin allow-forms allow-top-navigation".
-  <a href="file_iframe_sandbox_k_if5.html" target="_blank" id="target_blank_if5" rel="opener">open window</a>
+  <a href="file_iframe_sandbox_k_if5.html" target="_blank" id="target_blank_if5">open window</a>
   <a href="file_iframe_sandbox_k_if5.html" target="BC766282_if5" id="target_BC766282_if5">open window</a>
 
-  <a href="file_iframe_sandbox_k_if7.html" target="_blank" id="target_blank_if7" rel="opener">open window</a>
+  <a href="file_iframe_sandbox_k_if7.html" target="_blank" id="target_blank_if7">open window</a>
   <a href="file_iframe_sandbox_k_if7.html" target="BC766282_if7" id="target_BC766282_if7">open window</a>
 </body>
 </html>
--- a/dom/html/test/file_iframe_sandbox_k_if8.html
+++ b/dom/html/test/file_iframe_sandbox_k_if8.html
@@ -21,16 +21,16 @@
   window.doSubOpens = doSubOpens;
 </script>
 
 <body>
   I am sandboxed but with "allow-scripts allow-popups allow-same-origin".
   After my initial load, "allow-same-origin" is removed and then I open file_iframe_sandbox_k_if9.html
   in 3 different ways, which attemps to call a function in my parent.
   This should succeed since the new sandbox flags shouldn't have taken affect on me until I'm reloaded.
-  <a href="file_iframe_sandbox_k_if9.html" target="_blank" id="target_blank_if9" rel="opener">open window</a>
+  <a href="file_iframe_sandbox_k_if9.html" target="_blank" id="target_blank_if9">open window</a>
   <a href="file_iframe_sandbox_k_if9.html" target="BC766282_if9" id="target_BC766282_if9">open window</a>
 
   Now navigate to file_iframe_sandbox_k_if1.html to do tests for a sandbox opening a window
   when only "allow-scripts allow-popups" are specified.
   <a href="file_iframe_sandbox_k_if1.html" id="target_if1">navigate to if1</a>
 </body>
 </html>
--- a/dom/html/test/file_window_open_close_outer.html
+++ b/dom/html/test/file_window_open_close_outer.html
@@ -1,5 +1,5 @@
 <html>
 <body>
-<a id="link" href="file_window_open_close_inner.html" target="_blank" rel="opener" onclick="setTimeout(function () { window.close() }, 0)">link</a>
+<a id="link" href="file_window_open_close_inner.html" target="_blank" onclick="setTimeout(function () { window.close() }, 0)">link</a>
 </html>
 </body>
deleted file mode 100644
index 51e8aaf38c1b3a105fc6038c93b5648a4bf9efd4..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
--- a/dom/security/test/mixedcontentblocker/file_frameNavigation_blankTarget.html
+++ b/dom/security/test/mixedcontentblocker/file_frameNavigation_blankTarget.html
@@ -4,17 +4,17 @@
 Tests for Mixed Content Blocker - Opening link with _blank target in an https iframe.
 https://bugzilla.mozilla.org/show_bug.cgi?id=841850
 -->
 <head>
   <meta charset="utf-8">
   <title>Tests for Mixed Content Frame Navigation</title>
 </head>
 <body>
-<a href="http://example.com/tests/dom/security/test/mixedcontentblocker/file_frameNavigation_innermost.html?blankTarget" id="blankTarget" target="_blank" rel="opener">Go to http site</a>
+<a href="http://example.com/tests/dom/security/test/mixedcontentblocker/file_frameNavigation_innermost.html?blankTarget" id="blankTarget" target="_blank">Go to http site</a>
 
 <script>
   var blankTarget = document.getElementById("blankTarget");
   blankTarget.click();
 
   var observer = {
     observe: function(subject, topic, data) {
       //Subject location check added for Bug 1391823 to avoid removeAsyncObserver from being called multiple times
--- a/dom/tests/browser/test_noopener_source.html
+++ b/dom/tests/browser/test_noopener_source.html
@@ -1,9 +1,9 @@
-<a id="test1" href="test_noopener_target.html" target="_blank" rel="opener">1</a>
+<a id="test1" href="test_noopener_target.html" target="_blank">1</a>
 <a id="test2" href="test_noopener_target.html" target="_blank" rel="noopener">2</a>
 <a id="test3" href="test_noopener_target.html" target="_blank" rel="noreferrer">3</a>
 
 <a id="test4" href="test_noopener_target.html" target="uniquename1">4</a>
 <a id="test5" href="test_noopener_target.html" target="uniquename2" rel="noopener">5</a>
 <a id="test6" href="test_noopener_target.html" target="uniquename3" rel="noreferrer">6</a>
 
 <a id="test7" onclick="window.open('test_noopener_target.html', '_blank')">7</a>
--- a/dom/tests/mochitest/bugs/test_bug458091.html
+++ b/dom/tests/mochitest/bugs/test_bug458091.html
@@ -11,18 +11,18 @@ https://bugzilla.mozilla.org/show_bug.cg
 </head>
 <body>
 <a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=458091">Mozilla Bug 458091</a>
 
 <div id="content" style="display: none">
 
 </div>
 <pre id="test">
-<a id="testlink1" target="_blank" rel="opener" href="javascript:window.opener.finish(sessionStorage['testItem']);window.close();">Javascript Link</a>
-<a id="testlink2" target="_blank" rel="opener" href="bug458091_child.html">HTTP Link</a>
+<a id="testlink1" target="_blank" href="javascript:window.opener.finish(sessionStorage['testItem']);window.close();">Javascript Link</a>
+<a id="testlink2" target="_blank" href="bug458091_child.html">HTTP Link</a>
 <a id="testlink3" target="alreadyOpened" href="bug458091_child.html">Target Link</a>
 <script type="application/javascript">
 
 /** Test for Bug 458091 **/
 
 var gTestWin;
 var gRunningTests = 0;
 
--- a/modules/libpref/init/StaticPrefList.h
+++ b/modules/libpref/init/StaticPrefList.h
@@ -455,30 +455,16 @@ VARCACHE_PREF(
 
 // Block multiple window.open() per single event.
 VARCACHE_PREF(
   "dom.block_multiple_popups",
    dom_block_multiple_popups,
   bool, true
 )
 
-// For area and anchor elements with target=_blank and no rel set to
-// opener/noopener, this pref sets noopener by default.
-#ifdef EARLY_BETA_OR_EARLIER
-#define PREF_VALUE true
-#else
-#define PREF_VALUE false
-#endif
-VARCACHE_PREF(
-  "dom.targetBlankNoOpener.enabled",
-   dom_targetBlankNoOpener_enabled,
-  bool, PREF_VALUE
-)
-#undef PREF_VALUE
-
 //---------------------------------------------------------------------------
 // Clear-Site-Data prefs
 //---------------------------------------------------------------------------
 
 VARCACHE_PREF(
   "dom.clearSiteData.enabled",
    dom_clearSiteData_enabled,
   bool, true
deleted file mode 100644
--- a/testing/web-platform/meta/FileAPI/url/__dir__.ini
+++ /dev/null
@@ -1,1 +0,0 @@
-prefs: [dom.targetBlankNoOpener.enabled:false]
deleted file mode 100644
--- a/testing/web-platform/meta/content-security-policy/unsafe-hashes/__dir__.ini
+++ /dev/null
@@ -1,1 +0,0 @@
-prefs: [dom.targetBlankNoOpener.enabled:false]
deleted file mode 100644
--- a/testing/web-platform/meta/html/browsers/windows/auxiliary-browsing-contexts/__dir__.ini
+++ /dev/null
@@ -1,1 +0,0 @@
-prefs: [dom.targetBlankNoOpener.enabled:false]
deleted file mode 100644
--- a/testing/web-platform/meta/html/semantics/embedded-content/the-iframe-element/__dir__.ini
+++ /dev/null
@@ -1,1 +0,0 @@
-prefs: [dom.targetBlankNoOpener.enabled:false]
deleted file mode 100644
--- a/testing/web-platform/meta/html/semantics/links/links-created-by-a-and-area-elements/__dir__.ini
+++ /dev/null
@@ -1,1 +0,0 @@
-prefs: [dom.targetBlankNoOpener.enabled:true]
deleted file mode 100644
--- a/testing/web-platform/tests/html/semantics/links/links-created-by-a-and-area-elements/support/target_blank_iplicit_noopener.html
+++ /dev/null
@@ -1,6 +0,0 @@
-<!DOCTYPE html>
-<script>
-  let bc = new BroadcastChannel(window.location.search.substring(1));
-  bc.postMessage({ hasOpener: opener !== null });
-  window.close();
-</script>
deleted file mode 100644
--- a/testing/web-platform/tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.tentative.html
+++ /dev/null
@@ -1,60 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-  <meta charset=utf-8>
-  <title>Test behavior of rel="noopener" links</title>
-  <script src=/resources/testharness.js></script>
-  <script src=/resources/testharnessreport.js></script>
-</head>
-<body>
-  <a href="support/target_blank_iplicit_noopener.html?a1" id="a1" rel="noopener" target="_blank">Click me</a>
-  <a href="support/target_blank_iplicit_noopener.html?a2" id="a2" rel="opener" target="_blank">Click me</a>
-  <a href="support/target_blank_iplicit_noopener.html?a3" id="a3" target="_blank">Click me</a>
-  <a href="support/target_blank_iplicit_noopener.html?a4" id="a4" rel="opener noopener" target="_blank">Click me</a>
-  <a href="support/target_blank_iplicit_noopener.html?a5" id="a5" rel="noopener opener" target="_blank">Click me</a>
-
-  <img src="/images/threecolors.png" />
-    <area shape="rect" coords="0,0,99,50" href="support/target_blank_iplicit_noopener.html?area1" id="area1" rel="noopener" target="_blank" />
-  </img>
-  <img src="/images/threecolors.png" />
-    <area shape="rect" coords="0,0,99,50" href="support/target_blank_iplicit_noopener.html?area2" id="area2" rel="opener" target="_blank" />
-  </img>
-  <img src="/images/threecolors.png" />
-    <area shape="rect" coords="0,0,99,50" href="support/target_blank_iplicit_noopener.html?area3" id="area3" target="_blank" />
-  </img>
-  <img src="/images/threecolors.png" />
-    <area shape="rect" coords="0,0,99,50" href="support/target_blank_iplicit_noopener.html?area4" id="area4" rel="opener noopener" target="_blank" />
-  </img>
-  <img src="/images/threecolors.png" />
-    <area shape="rect" coords="0,0,99,50" href="support/target_blank_iplicit_noopener.html?area5" id="area5" rel="noopener opener" target="_blank" />
-  </img>
-
-  <script>
-
-  let tests = [
-    { id: "a1", hasOpener: false, name: "Anchor element with target=_blank with rel=noopener" },
-    { id: "a2", hasOpener: true, name: "Anchor element with target=_blank with rel=opener" },
-    { id: "a3", hasOpener: false, name: "Anchor element with target=_blank with implicit rel=noopener" },
-    { id: "a4", hasOpener: false, name: "Anchor element with target=_blank with rel=opener+noopener" },
-    { id: "a5", hasOpener: false, name: "Anchor element with target=_blank with rel=noopener+opener" },
-    { id: "area1", hasOpener: false, name: "Area element with target=_blank with rel=noopener" },
-    { id: "area2", hasOpener: true, name: "Area element with target=_blank with rel=opener" },
-    { id: "area3", hasOpener: false, name: "Area element with target=_blank with implicit rel=noopener" },
-    { id: "area4", hasOpener: false, name: "Area element with target=_blank with rel=opener+noopener" },
-    { id: "area5", hasOpener: false, name: "Area element with target=_blank with rel=noopener+opener" },
-  ];
-
-  tests.forEach(data => {
-    async_test(
-      test => {
-        let bc = new BroadcastChannel(data.id);
-        bc.addEventListener("message", test.step_func_done(e => {
-          assert_equals(e.data.hasOpener, data.hasOpener);
-        }), {once: true});
-
-        document.getElementById(data.id).click();
-      }, data.name);
-  });
-  </script>
-</body>
-</html>
--- a/toolkit/components/extensions/test/mochitest/head_webrequest.js
+++ b/toolkit/components/extensions/test/mochitest/head_webrequest.js
@@ -333,17 +333,16 @@ function addStylesheet(file) {
 }
 
 /* exported addLink */
 
 function addLink(file) {
   let a = document.createElement("a");
   a.setAttribute("href", file);
   a.setAttribute("target", "_blank");
-  a.setAttribute("rel", "opener");
   document.body.appendChild(a);
   return a;
 }
 
 /* exported addImage */
 
 function addImage(file) {
   let img = document.createElement("img");
--- a/toolkit/components/extensions/test/mochitest/test_ext_new_tab_processType.html
+++ b/toolkit/components/extensions/test/mochitest/test_ext_new_tab_processType.html
@@ -37,17 +37,17 @@ add_task(async function test_target_blan
 
       web_accessible_resources: ["iframe.html"],
     },
     files: {
       "iframe.html": `<!DOCTYPE html>
         <html>
           <head><meta charset="utf-8"></html>
           <body>
-            <a href="${linkURL}" target="_blank" id="link" rel="opener">link</a>
+            <a href="${linkURL}" target="_blank" id="link">link</a>
           </body>
         </html>`,
     },
     background() {
       browser.test.sendMessage("frame_url", browser.runtime.getURL("iframe.html"));
     },
   });
 
--- a/uriloader/exthandler/tests/mochitest/download_page.html
+++ b/uriloader/exthandler/tests/mochitest/download_page.html
@@ -8,12 +8,12 @@
   <script type="text/javascript">
     function launch_download() {
       window.open("download.sjs", "_blank", "height=100,width=100");
     }
   </script>
 </head>
 <body>
   <a href="download.bin" id="regular_load">regular load</a>
-  <a href="download.bin" id="target_blank" target="_blank" rel="opener">target blank</a>
+  <a href="download.bin" id="target_blank" target="_blank">target blank</a>
   <a href="#" onclick="launch_download(); return false" id="new_window">new window</a>
   <a href="#" onclick="window.open('download_page.html?newwin'); return false" id="open_in_new_tab">click to reopen</a>
 </body>