Bug 1518229 - Allow clear-text network traffic in Android manifest. r=nalexander
authorJan Henning <jh+bugzilla@buttercookie.de>
Mon, 14 Jan 2019 18:16:19 +0000
changeset 453765 b45954a2a5b8f59dd7b22c7dc85722f414a3613b
parent 453764 041c4580aa6f1f23bd0fcc5349026f7abd5f31f7
child 453766 93c0ed8f369080be59f2dd3a705e9fd8290f7813
push id35372
push usercbrindusan@mozilla.com
push dateMon, 14 Jan 2019 21:49:33 +0000
treeherdermozilla-central@50b3268954b1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1518229
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1518229 - Allow clear-text network traffic in Android manifest. r=nalexander Needs to be explicitly declared in case we start targeting Android P. It's unclear to what extent this is really required when *not* using Android's network stack directly, but at least with Firefox, some things definitively use it, e.g. favicons. As we're a browser, we need to allow access to arbitrary pages, so just generally white-list it. Differential Revision: https://phabricator.services.mozilla.com/D16408
mobile/android/base/AndroidManifest.xml.in
mobile/android/geckoview_example/src/main/AndroidManifest.xml
--- a/mobile/android/base/AndroidManifest.xml.in
+++ b/mobile/android/base/AndroidManifest.xml.in
@@ -25,16 +25,17 @@
 
     <application android:label="@string/moz_app_displayname"
                  android:icon="@mipmap/ic_launcher"
                  android:logo="@drawable/logo"
                  android:name="@MOZ_ANDROID_APPLICATION_CLASS@"
                  android:hardwareAccelerated="true"
                  android:supportsRtl="true"
                  android:allowBackup="false"
+                 android:usesCleartextTraffic="true"
                  >
 
         <meta-data android:name="com.sec.android.support.multiwindow" android:value="true"/>
 
         <meta-data android:name="android.max_aspect" android:value="2.1"/>
 
 #ifdef MOZ_NATIVE_DEVICES
         <service android:name="org.mozilla.gecko.RemotePresentationService" android:exported="false"/>
--- a/mobile/android/geckoview_example/src/main/AndroidManifest.xml
+++ b/mobile/android/geckoview_example/src/main/AndroidManifest.xml
@@ -7,17 +7,18 @@
     <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>
     <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
     <uses-permission android:name="android.permission.RECORD_AUDIO"/>
     <uses-permission android:name="android.permission.CAMERA"/>
 
     <application
             android:allowBackup="true"
             android:label="@string/app_name"
-            android:supportsRtl="true">
+            android:supportsRtl="true"
+            android:usesCleartextTraffic="true">
         <uses-library android:name="android.test.runner"/>
 
         <activity
                 android:name=".GeckoViewActivity"
                 android:label="GeckoView Example"
                 android:launchMode="singleTop"
                 android:theme="@style/Theme.AppCompat.Light.NoActionBar"
                 android:windowSoftInputMode="stateUnspecified|adjustResize">