Bug 1750148 - Remove unused PrimitiveOpacity::combine. r=gfx-reviewers,jnicol
authorMike Hommey <mh+mozilla@glandium.org>
Fri, 14 Jan 2022 21:05:03 +0000
changeset 604602 b439d416831424beda57c4169a8ecb5cf39a0d29
parent 604601 e62fee2d69c5222c8fea1449b67e75fa3ea38fc8
child 604603 33580fdf015f42a1dcae0ba2b223569ed684b5a7
push id39152
push userabutkovits@mozilla.com
push dateSat, 15 Jan 2022 09:45:36 +0000
treeherdermozilla-central@60998033086a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgfx-reviewers, jnicol
bugs1750148
milestone98.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1750148 - Remove unused PrimitiveOpacity::combine. r=gfx-reviewers,jnicol It causes a dead-code warning on rust 1.60 that we turn into error. Differential Revision: https://phabricator.services.mozilla.com/D135972
gfx/wr/webrender/src/prim_store/mod.rs
--- a/gfx/wr/webrender/src/prim_store/mod.rs
+++ b/gfx/wr/webrender/src/prim_store/mod.rs
@@ -86,22 +86,16 @@ impl PrimitiveOpacity {
         PrimitiveOpacity { is_opaque: false }
     }
 
     pub fn from_alpha(alpha: f32) -> PrimitiveOpacity {
         PrimitiveOpacity {
             is_opaque: alpha >= 1.0,
         }
     }
-
-    pub fn combine(self, other: PrimitiveOpacity) -> PrimitiveOpacity {
-        PrimitiveOpacity{
-            is_opaque: self.is_opaque && other.is_opaque
-        }
-    }
 }
 
 /// For external images, it's not possible to know the
 /// UV coords of the image (or the image data itself)
 /// until the render thread receives the frame and issues
 /// callbacks to the client application. For external
 /// images that are visible, a DeferredResolve is created
 /// that is stored in the frame. This allows the render