Bug 1149754 - Part 4: Fix duplicated ping saving. r=dexter
authorGeorg Fritzsche <georg.fritzsche@googlemail.com>
Thu, 30 Apr 2015 14:00:58 +0200
changeset 241832 b30b620283bd852a543a0bd08928745a0c6f9f68
parent 241831 bd3b4ef4eedd20595773a6d9f3de14e39a664f06
child 241833 833051c87c7be1a34d716c51ab50a4431d248be9
push id28671
push userryanvm@gmail.com
push dateFri, 01 May 2015 14:27:58 +0000
treeherdermozilla-central@60b269fed8cf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdexter
bugs1149754
milestone40.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1149754 - Part 4: Fix duplicated ping saving. r=dexter
toolkit/components/telemetry/TelemetryStorage.jsm
--- a/toolkit/components/telemetry/TelemetryStorage.jsm
+++ b/toolkit/components/telemetry/TelemetryStorage.jsm
@@ -438,18 +438,17 @@ let TelemetryStorageImpl = {
    */
   addPendingPingFromFile: function(pingPath) {
     // Pings in the saved ping directory need to have the ping id or slug (old format) as
     // the file name. We load the ping content, check that it is valid, and use it to save
     // the ping file with the correct file name.
     return this.loadPingFile(pingPath).then(ping => {
       // Since we read a ping successfully, update the related histogram.
       Telemetry.getHistogramById("READ_SAVED_PING_SUCCESS").add(1);
-      this.addPendingPing(ping);
-      return this.savePing(ping, false);
+      return this.addPendingPing(ping);
     });
   },
 
   /**
    * Add a ping to the saved pings directory so that it gets saved
    * and sent along with other pings.
    * Note: that the original ping file will not be modified.
    *