Bug 1486220 - Revert document.createXULElement change from Bug 1485426 in videocontrols.xml;r=me
authorBrian Grinstead <bgrinstead@mozilla.com>
Sun, 26 Aug 2018 06:26:35 -0700
changeset 433422 b2d0cb1ce26f5f3f19a7bd65c74ebf82c6e7d53e
parent 433421 2d0ebe0ace0b3086f03c39e1d959b1ee92165c3b
child 433423 8d42de3d92450c461967fe102959dba7b71ff663
push id34511
push userapavel@mozilla.com
push dateSun, 26 Aug 2018 21:48:43 +0000
treeherdermozilla-central@e4e2245fc142 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1486220, 1485426
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1486220 - Revert document.createXULElement change from Bug 1485426 in videocontrols.xml;r=me Since videocontrols run in content, this is generally a content privileged HTML document which doesn't have access to that API. And besides, we actually want this to be an <html:button>.
toolkit/content/widgets/videocontrols.xml
--- a/toolkit/content/widgets/videocontrols.xml
+++ b/toolkit/content/widgets/videocontrols.xml
@@ -1613,17 +1613,17 @@
           }
           return;
         }
 
         tt.index = this.textTracksCount++;
 
         const label = tt.label || "";
         const ttText = document.createTextNode(label);
-        const ttBtn = document.createXULElement("button");
+        const ttBtn = document.createElement("button");
 
         ttBtn.classList.add("textTrackItem");
         ttBtn.setAttribute("index", tt.index);
         ttBtn.appendChild(ttText);
 
         this.textTrackList.appendChild(ttBtn);
 
         if (tt.mode === "showing" && tt.index) {