Backed out changeset 8d9b4e8dce57 (bug 1343014) for failing dt at rowser_device_width.js on a CLOSED TREE
authorAndreea Pavel <apavel@mozilla.com>
Wed, 20 Mar 2019 00:16:05 +0200
changeset 465119 b29882123ec6753ce6292d1affec84669711d3bf
parent 465118 26fafa29a3eb557f9e41ecd9e6821052475055ce
child 465120 ad7c396900da2c0c27e3080c3926dceb784a8780
push id35732
push useropoprus@mozilla.com
push dateWed, 20 Mar 2019 10:52:37 +0000
treeherdermozilla-central@708979f9c3f3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1343014
milestone68.0a1
backs out8d9b4e8dce578a417cc0f2f98eaebe3cef47370f
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 8d9b4e8dce57 (bug 1343014) for failing dt at rowser_device_width.js on a CLOSED TREE
devtools/client/responsive.html/components/ViewportDimension.js
devtools/client/responsive.html/index.css
--- a/devtools/client/responsive.html/components/ViewportDimension.js
+++ b/devtools/client/responsive.html/components/ViewportDimension.js
@@ -157,17 +157,16 @@ class ViewportDimension extends PureComp
       },
       dom.input({
         ref: input => {
           this.widthInput = input;
         },
         className: "text-input viewport-dimension-input" +
                    (this.state.isWidthValid ? "" : " invalid"),
         size: 4,
-        type: "number",
         value: this.state.width,
         onBlur: this.onInputBlur,
         onChange: this.onInputChange,
         onFocus: this.onInputFocus,
         onKeyDown: this.onInputKeyDown,
         onKeyUp: this.onInputKeyUp,
       }),
       dom.span({
@@ -175,17 +174,16 @@ class ViewportDimension extends PureComp
       }, "×"),
       dom.input({
         ref: input => {
           this.heightInput = input;
         },
         className: "text-input viewport-dimension-input" +
                    (this.state.isHeightValid ? "" : " invalid"),
         size: 4,
-        type: "number",
         value: this.state.height,
         onBlur: this.onInputBlur,
         onChange: this.onInputChange,
         onFocus: this.onInputFocus,
         onKeyDown: this.onInputKeyDown,
         onKeyUp: this.onInputKeyUp,
       })
     );
--- a/devtools/client/responsive.html/index.css
+++ b/devtools/client/responsive.html/index.css
@@ -355,17 +355,16 @@ body,
   display: flex;
   align-items: center;
   margin: 1px;
 }
 
 .viewport-dimension-input {
   text-align: center;
   width: 3em;
-  -moz-appearance: textfield;
 }
 
 .viewport-dimension-separator {
   -moz-user-select: none;
   padding: 0 0.3em;
 }
 
 /**