Bug 1187664 - Don't run gst-plugin-scanner through valgrind, it only leads to irrelevant errors. r=njn
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 29 Jul 2015 17:27:05 +0900
changeset 256006 b28d496da7bf48432cb3aac3d10e7a66a267421c
parent 256005 1e2f1521b7e8226aba3e5d828b3eb8e569ac6886
child 256007 a9d3df6e14e030bd356712c4520deea64473009f
push id29163
push usercbook@mozilla.com
push dateTue, 04 Aug 2015 11:01:35 +0000
treeherdermozilla-central@5cf4d2f7f2f2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1187664
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1187664 - Don't run gst-plugin-scanner through valgrind, it only leads to irrelevant errors. r=njn
build/valgrind/mach_commands.py
--- a/build/valgrind/mach_commands.py
+++ b/build/valgrind/mach_commands.py
@@ -106,16 +106,23 @@ class MachCommands(MachCommandBase):
                 '--smc-check=all-non-file',
                 '--vex-iropt-register-updates=allregs-at-mem-access',
                 '--gen-suppressions=all',
                 '--num-callers=36',
                 '--leak-check=full',
                 '--show-possibly-lost=no',
                 '--track-origins=yes',
                 '--trace-children=yes',
+                # The gstreamer plugin scanner can run as part of executing
+                # firefox, but is an external program. In some weird cases,
+                # valgrind finds errors while executing __libc_freeres when
+                # it runs, but those are not relevant, as it's related to
+                # executing third party code. So don't trace
+                # gst-plugin-scanner.
+                '--trace-children-skip=*/gst-plugin-scanner',
                 '-v',  # Enable verbosity to get the list of used suppressions
             ]
 
             for s in suppressions:
                 valgrind_args.append('--suppressions=' + s)
 
             supps_dir = os.path.join(build_dir, 'valgrind')
             supps_file1 = os.path.join(supps_dir, 'cross-architecture.sup')