Bug 1133286 - Remove nonstandard expression closures from docshell/test. r=bz
authorChris Peterson <cpeterson@mozilla.com>
Sat, 24 Jan 2015 23:54:17 -0800
changeset 229833 b213954a5d30d946088cc8267d7c064753cec0a4
parent 229832 55e4ab92ff9470bfeadb60a999d4833205cb426d
child 229834 d563f8e2d157bf939a02671a59e97b94a2618248
push id28300
push userryanvm@gmail.com
push dateThu, 19 Feb 2015 23:52:47 +0000
treeherdermozilla-central@56f090df5480 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs1133286
milestone38.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1133286 - Remove nonstandard expression closures from docshell/test. r=bz
docshell/test/browser/browser_bug422543.js
docshell/test/browser/browser_bug670318.js
docshell/test/navigation/test_bug386782.html
--- a/docshell/test/browser/browser_bug422543.js
+++ b/docshell/test/browser/browser_bug422543.js
@@ -122,17 +122,17 @@ function notifyReload() {
   let shistory = browser.docShell.sessionHistory;
   shistory.QueryInterface(Ci.nsISHistoryInternal);
   return shistory.notifyOnHistoryReload(browser.currentURI, 0);
 }
 
 function setup(aCallback) {
   let tab = gBrowser.selectedTab = gBrowser.addTab("about:mozilla");
   let browser = tab.linkedBrowser;
-  registerCleanupFunction(function () gBrowser.removeTab(tab));
+  registerCleanupFunction(function () { gBrowser.removeTab(tab); });
 
   whenPageShown(browser, function () {
     gFirstListener = new SHistoryListener();
     gSecondListener = new SHistoryListener();
 
     let shistory = browser.docShell.sessionHistory;
     shistory.addSHistoryListener(gFirstListener);
     shistory.addSHistoryListener(gSecondListener);
--- a/docshell/test/browser/browser_bug670318.js
+++ b/docshell/test/browser/browser_bug670318.js
@@ -23,28 +23,28 @@ function test() {
 
           ok(history.index < history.count, "history.index is valid");
           finish();
         }, true);
 
         history.removeSHistoryListener(listener);
         historyListenerRemoved = true;
 
-        executeSoon(function () BrowserReload());
+        executeSoon(function () { BrowserReload(); });
       }
 
       return true;
     },
 
-    OnHistoryReload: function () true,
-    OnHistoryGoBack: function () true,
-    OnHistoryGoForward: function () true,
-    OnHistoryGotoIndex: function () true,
-    OnHistoryPurge: function () true,
-    OnHistoryReplaceEntry: function () true,
+    OnHistoryReload: () => true,
+    OnHistoryGoBack: () => true,
+    OnHistoryGoForward: () => true,
+    OnHistoryGotoIndex: () => true,
+    OnHistoryPurge: () => true,
+    OnHistoryReplaceEntry: () => true,
 
     QueryInterface: XPCOMUtils.generateQI([Ci.nsISHistoryListener,
                                            Ci.nsISupportsWeakReference])
   };
 
   let tab = gBrowser.loadOneTab(URL, {inBackground: false});
   let browser = tab.linkedBrowser;
   let history = browser.sessionHistory;
--- a/docshell/test/navigation/test_bug386782.html
+++ b/docshell/test/navigation/test_bug386782.html
@@ -18,17 +18,17 @@ https://bugzilla.mozilla.org/show_bug.cg
     // the editable region is not in the root docshell (a less complicated case).  
 
   
     var gTests = [
       {
         // <html><body><p>designModeDocument</p></body></html>
         url: "data:text/html;charset=utf-8,<html><body><p>designModeDocument</p></body></html>",
         name: 'designModeNavigate',
-        onload: function(doc) doc.designMode = "on",
+        onload(doc) { doc.designMode = "on"; },
         expectedBodyBeforeEdit: '<p>designModeDocument</p>',
         expectedBodyAfterEdit:  '<p>EDITED designModeDocument</p>',
         expectedBodyAfterSecondEdit: '<p>EDITED TWICE designModeDocument</p>',
       },
       {
         // <html><body contentEditable="true"><p>contentEditable</p></body></html>
         url: 'data:text/html;charset=utf-8,<html><body contentEditable="true"><p>contentEditable</p></body></html>',
         name: 'contentEditableNavigate',