Bug 1613683 - Ship WebRender on Intel/AMD devices with small screens and a battery to beta. r=jrmuizel
authorAndrew Osmond <aosmond@mozilla.com>
Mon, 10 Feb 2020 20:27:12 +0000
changeset 513127 b1c545e004154c23d47600769388ed61a3d21ad7
parent 513126 07ba3a3f8ce6b144c20ec7b23b32685b10f8f06e
child 513128 1e9ff9a16b57fbec3789f5a692653b43935f6776
push id37110
push usernbeleuzu@mozilla.com
push dateTue, 11 Feb 2020 09:46:07 +0000
treeherdermozilla-central@11c9c5ce3955 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjrmuizel
bugs1613683
milestone75.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1613683 - Ship WebRender on Intel/AMD devices with small screens and a battery to beta. r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D62321
gfx/thebes/gfxPlatform.cpp
--- a/gfx/thebes/gfxPlatform.cpp
+++ b/gfx/thebes/gfxPlatform.cpp
@@ -2913,17 +2913,17 @@ static void UpdateWRQualificationForAMD(
     // for 1080p or smaller screens. For larger screens, it remains disabled by
     // default.
     const int64_t kMaxPixelsBattery = 1920 * 1200;  // WUXGA
     if (aScreenPixels <= 0) {
       aFeature.Disable(
           FeatureStatus::BlockedScreenUnknown, "Screen size unknown",
           NS_LITERAL_CSTRING("FEATURE_FAILURE_SCREEN_SIZE_UNKNOWN"));
     } else if (aScreenPixels <= kMaxPixelsBattery) {
-#    ifdef NIGHTLY_BUILD
+#    ifdef EARLY_BETA_OR_EARLIER
       // Battery and small screen, it should be on by default in nightly.
       *aOutGuardedByQualifiedPref = false;
 #    else
       aFeature.Disable(
           FeatureStatus::BlockedReleaseChannelBattery,
           "Release channel and battery",
           NS_LITERAL_CSTRING("FEATURE_FAILURE_RELEASE_CHANNEL_BATTERY"));
 #    endif  // !NIGHTLY_BUILD
@@ -3105,18 +3105,19 @@ static void UpdateWRQualificationForInte
   }
   if (aHasBattery) {
 #    ifndef XP_WIN
     // aHasBattery is only ever true on Windows, we don't check it on other
     // platforms.
     MOZ_ASSERT(false);
 #    endif
     if (aScreenPixels <= kMaxPixelsBattery) {
-#    ifdef NIGHTLY_BUILD
-      // Battery and small screen, it should be on by default in nightly.
+#    ifdef EARLY_BETA_OR_EARLIER
+      // Battery and small screen, it should be on by default in nightly and
+      // beta.
       *aOutGuardedByQualifiedPref = false;
 #    else
       aFeature.Disable(
           FeatureStatus::BlockedReleaseChannelBattery,
           "Release channel and battery",
           NS_LITERAL_CSTRING("FEATURE_FAILURE_RELEASE_CHANNEL_BATTERY"));
       return;
 #    endif  // !NIGHTLY_BUILD