author | Byron Campen [:bwc] <docfaraday@gmail.com> |
Fri, 26 Apr 2019 15:56:15 +0000 | |
changeset 471535 | b13f2b24ae625d16fdeeb61cdec10978c3c75638 |
parent 471534 | 434766cf660f8af665892473b7eb8a4b98b8e0f9 |
child 471536 | 348e150188840f913d58a89d2d591ab9ef572dd8 |
child 471634 | f31fa29b2a08aa51ed1a917444b9780483523111 |
push id | 35920 |
push user | aiakab@mozilla.com |
push date | Fri, 26 Apr 2019 22:02:33 +0000 |
treeherder | mozilla-central@b13f2b24ae62 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | jib |
bugs | 1531894 |
milestone | 68.0a1 |
first release with | nightly linux32
b13f2b24ae62
/
68.0a1
/
20190426220233
/
files
nightly linux64
b13f2b24ae62
/
68.0a1
/
20190426220233
/
files
nightly mac
b13f2b24ae62
/
68.0a1
/
20190426220233
/
files
nightly win32
b13f2b24ae62
/
68.0a1
/
20190426220233
/
files
nightly win64
b13f2b24ae62
/
68.0a1
/
20190426220233
/
files
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
releases | nightly linux32
68.0a1
/
20190426220233
/
pushlog to previous
nightly linux64
68.0a1
/
20190426220233
/
pushlog to previous
nightly mac
68.0a1
/
20190426220233
/
pushlog to previous
nightly win32
68.0a1
/
20190426220233
/
pushlog to previous
nightly win64
68.0a1
/
20190426220233
/
pushlog to previous
|
--- a/dom/media/PeerConnection.jsm +++ b/dom/media/PeerConnection.jsm @@ -1623,17 +1623,17 @@ class RTCPeerConnection { id = null; } else if (id === null) { throw new this._win.DOMException( "id is required when negotiated is true", "TypeError"); } if (maxPacketLifeTime !== undefined && maxRetransmits !== undefined) { throw new this._win.DOMException( "Both maxPacketLifeTime and maxRetransmits cannot be provided", - "InvalidParameterError"); + "TypeError"); } if (id == 65535) { throw new this._win.DOMException( "id cannot be 65535", "TypeError"); } // Must determine the type where we still know if entries are undefined. let type; if (maxPacketLifeTime !== undefined) {
--- a/testing/web-platform/meta/webrtc/RTCPeerConnection-createDataChannel.html.ini +++ b/testing/web-platform/meta/webrtc/RTCPeerConnection-createDataChannel.html.ini @@ -2,20 +2,16 @@ [createDataChannel attribute default values] expected: FAIL bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1529695 [createDataChannel with provided parameters should initialize attributes to provided values] expected: FAIL bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1531900 - [createDataChannel with both maxPacketLifeTime and maxRetransmits should throw SyntaxError] - expected: FAIL - bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1531894 - [createDataChannel with negotiated true should succeed] expected: FAIL bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1529695 [createDataChannel with priority "high" should succeed] expected: FAIL bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1531100 @@ -40,19 +36,16 @@ bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1526253 [createDataChannel with negotiated false should succeed] expected: FAIL [createDataChannel with negotiated false and id 42 should ignore the id] expected: FAIL - [createDataChannel with both maxPacketLifeTime and maxRetransmits should throw TypeError] - expected: FAIL - [Reusing a data channel id that is in use (after setRemoteDescription, negotiated via DCEP) should throw OperationError] expected: FAIL [Reusing a data channel id that is in use (after setRemoteDescription) should throw OperationError] expected: FAIL [New data channel should be in the connecting state after creation (after connection establishment)] expected: FAIL