Bug 782551 - Remove two quirks that other browsers don't have. r=bzbarsky
authorEmilio Cobos Álvarez <emilio@crisal.io>
Thu, 15 Aug 2019 15:57:42 +0000
changeset 488259 b1133e4b7e953cbb539e27ac7034b357a4e7b326
parent 488258 9a0528095590ff18f2e7fc87d1e1f2d81dd098d3
child 488260 d3b872e9aca1f511c540704d6354149b737e3d72
push id36440
push userncsoregi@mozilla.com
push dateFri, 16 Aug 2019 03:57:48 +0000
treeherdermozilla-central@a58b7dc85887 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbzbarsky
bugs782551
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 782551 - Remove two quirks that other browsers don't have. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D42148
layout/style/res/quirk.css
testing/web-platform/tests/quirks/dd-dl-firefox-001-ref.html
testing/web-platform/tests/quirks/dd-dl-firefox-001.html
--- a/layout/style/res/quirk.css
+++ b/layout/style/res/quirk.css
@@ -138,42 +138,16 @@ td > xmp:-moz-only-whitespace:-moz-last-
 td > pre:-moz-only-whitespace:-moz-last-node, th > pre:-moz-only-whitespace:-moz-last-node,
 td > ul:-moz-only-whitespace:-moz-last-node, th > ul:-moz-only-whitespace:-moz-last-node,
 td > menu:-moz-only-whitespace:-moz-last-node, th > menu:-moz-only-whitespace:-moz-last-node,
 td > dir:-moz-only-whitespace:-moz-last-node, th > dir:-moz-only-whitespace:-moz-last-node,
 td > ol:-moz-only-whitespace:-moz-last-node, th > ol:-moz-only-whitespace:-moz-last-node {
   margin-block-start: 0;
 }
 
-
-/* Quirk: DD not in DL has text-indent instead of margin (b=5119) */
-
-:not(dl) > dd {
-  display: inline;
-  margin: 0;
-}
-
-:not(dl) > dd:before {
-  display: inline;
-  white-space: pre;
-  font-size: 1px;
-  line-height: 0;
-  content: "\A  ";
-  margin-inline-end: 40px;
-}
-
-
-/* quirk to indent nested DL elements (b=8749) */
-
-dl > dl {
-  display: block;
-  margin-inline-start: 40px;
-}
-
-
 /* Quirk: Make floated images have a margin  (b=58899) */
 img[align=left]:dir(ltr), img[align=right]:dir(rtl) {
   margin-inline-end: 3px;
 }
 
 img[align=right]:dir(ltr), img[align=left]:dir(rtl) {
   margin-inline-start: 3px;
 }
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/quirks/dd-dl-firefox-001-ref.html
@@ -0,0 +1,8 @@
+<!doctype html>
+<title>CSS Test Reference</title>
+<div>Prevent quirky dl margin from messing up with us</div>
+<dl>
+  <dd>One</dd>
+  <dl>Two</dl>
+</dl>
+<dd>Three</dd><dd>Four</dd>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/quirks/dd-dl-firefox-001.html
@@ -0,0 +1,18 @@
+<!-- quirks -->
+<title>dd and dl don't have weird text-indent quirks</title>
+<link rel="match" href="dd-dl-firefox-001-ref.html">
+<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=782551">
+<link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io">
+<link rel="author" title="Mozilla" href="https://mozilla.org">
+<style>
+  /* Firefox used to (sometimes) implement dd indentation in quirks mode via
+     the ::before pseudo-element; this rule should do nothing in compliant
+     browsers */
+  dd::before { content: "" }
+</style>
+<div>Prevent quirky dl margin from messing up with us</div>
+<dl>
+  <dd>One</dd>
+  <dl>Two</dl>
+</dl>
+<dd>Three</dd><dd>Four</dd>