Bug 860941 - Make dialogArguments default to |undefined| rather than |null|. r=jst
authorBobby Holley <bobbyholley@gmail.com>
Fri, 17 May 2013 10:43:19 -0700
changeset 132268 af186224869402007bc54ad3aeeecdc0a9aa7fee
parent 132267 e4c145a09a94b954af5f806f2bc3137472a3a121
child 132269 8634d3597ee8a9a14ce1d07789788cd0e3219e12
push id24691
push userryanvm@gmail.com
push dateSat, 18 May 2013 01:41:18 +0000
treeherdermozilla-central@6e2789a70f6b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 860941 - Make dialogArguments default to |undefined| rather than |null|. r=jst This is correct by my reading of the spec. Quoting: The dialogArguments IDL attribute, on getting, must check whether its browsing context's active document's origin is the same as the dialog arguments' origin. If it is, then the browsing context's dialog arguments must be returned unchanged. Otherwise, if the dialog arguments are an object, then the empty string must be returned, and if the dialog arguments are not an object, then the stringification of the dialog arguments must be returned.
--- a/dom/base/nsGlobalWindow.cpp
+++ b/dom/base/nsGlobalWindow.cpp
@@ -7633,28 +7633,35 @@ ConvertDialogOptions(const nsAString& aO
-nsGlobalWindow::ShowModalDialog(const nsAString& aURI, nsIVariant *aArgs,
-                                const nsAString& aOptions,
+nsGlobalWindow::ShowModalDialog(const nsAString& aURI, nsIVariant *aArgs_,
+                                const nsAString& aOptions, uint8_t aArgc,
                                 nsIVariant **aRetVal)
-  FORWARD_TO_OUTER(ShowModalDialog, (aURI, aArgs, aOptions, aRetVal),
+  FORWARD_TO_OUTER(ShowModalDialog, (aURI, aArgs_, aOptions, aArgc, aRetVal),
   *aRetVal = nullptr;
   if (Preferences::GetBool("dom.disable_window_showModalDialog", false))
+  // Per-spec the |arguments| parameter is supposed to pass through unmodified.
+  // However, XPConnect default-initializes variants to null, rather than
+  // undefined. Fix this up here.
+  nsCOMPtr<nsIVariant> aArgs = aArgs_;
+  if (aArgc < 1) {
+    aArgs = CreateVoidVariant();
+  }
   nsRefPtr<DialogValueHolder> argHolder =
     new DialogValueHolder(nsContentUtils::GetSubjectPrincipal(), aArgs);
   // Before bringing up the window/dialog, unsuppress painting and flush
   // pending reflows.
   bool needToPromptForAbuse;
--- a/dom/interfaces/base/nsIDOMWindow.idl
+++ b/dom/interfaces/base/nsIDOMWindow.idl
@@ -20,17 +20,17 @@ interface nsIVariant;
  * The nsIDOMWindow interface is the primary interface for a DOM
  * window object. It represents a single window object that may
  * contain child windows if the document in the window contains a
  * HTML frameset document or if the document contains iframe elements.
  * @see <http://www.whatwg.org/html/#window>
-[scriptable, uuid(b4cf7214-5385-4f72-aa83-f8d1ff17252b)]
+[scriptable, uuid(e0f33b20-72ef-415b-9ff2-8bf176f581f8)]
 interface nsIDOMWindow : nsISupports
   // the current browsing context
   readonly attribute nsIDOMWindow                       window;
   /* [replaceable] self */
   readonly attribute nsIDOMWindow                       self;
@@ -189,16 +189,17 @@ interface nsIDOMWindow : nsISupports
   boolean                   confirm([optional] in DOMString text);
   // prompt() should return a null string if cancel is pressed
   DOMString                 prompt([optional] in DOMString aMessage,
                                    [optional] in DOMString aInitial);
   void                      print();
+  [optional_argc]
   nsIVariant                showModalDialog(in DOMString aURI,
                                             [optional] in nsIVariant aArgs,
                                             [optional] in DOMString aOptions);
   // cross-document messaging
    * Implements a safe message-passing system which can cross same-origin