Bug 1555454 - migrate webgl2-core tests to macosx1014 by disabling test_2_conformance2__textures__misc__tex-base-level-bug.html r=gbrown
authorEdwin Gao <egao@mozilla.com>
Thu, 04 Jul 2019 20:40:38 +0000
changeset 481326 af08b89eaae1b6285cf7c08441fa94967e1b728d
parent 481325 01f56f8016d50723b29209ec387fa19266181e59
child 481327 468437eadc5a7e8f3ff30a79ff3b8490712b683d
push id36239
push useropoprus@mozilla.com
push dateFri, 05 Jul 2019 06:46:18 +0000
treeherdermozilla-central@b7030ce607ec [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgbrown
bugs1555454
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1555454 - migrate webgl2-core tests to macosx1014 by disabling test_2_conformance2__textures__misc__tex-base-level-bug.html r=gbrown Changes: - remove `fail-if` conditions for tests that now pass on macosx1014 - add one `fail-if` condition for macosx1014 (`test_2_conformance2__textures__misc__tex-base-level-bug.html`) with approval from jgilbert - migrate mochitest-webgl2-core test to run on macosx1014 Differential Revision: https://phabricator.services.mozilla.com/D36982
dom/canvas/test/webgl-conf/generated-mochitest.ini
dom/canvas/test/webgl-conf/mochitest-errata.ini
taskcluster/ci/test/test-sets.yml
--- a/dom/canvas/test/webgl-conf/generated-mochitest.ini
+++ b/dom/canvas/test/webgl-conf/generated-mochitest.ini
@@ -5241,17 +5241,17 @@ subsuite = webgl2-core
 [generated/test_2_conformance2__query__occlusion-query.html]
 subsuite = webgl2-core
 skip-if = (os == 'win')
 [generated/test_2_conformance2__query__query.html]
 subsuite = webgl2-core
 skip-if = (os == 'win')
 [generated/test_2_conformance2__reading__format-r11f-g11f-b10f.html]
 subsuite = webgl2-core
-fail-if = (os == 'mac') || (os == "win" && processor == "aarch64") #aarch64 due to bug 1536182
+fail-if = (os == "win" && processor == "aarch64") #aarch64 due to bug 1536182
 [generated/test_2_conformance2__reading__read-pixels-from-fbo-test.html]
 subsuite = webgl2-core
 skip-if = (os == 'mac') || (os == 'win')
 [generated/test_2_conformance2__reading__read-pixels-from-rgb8-into-pbo-bug.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__reading__read-pixels-into-pixel-pack-buffer.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__reading__read-pixels-pack-parameters.html]
@@ -6849,46 +6849,42 @@ subsuite = webgl2-core
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__copy-texture-cube-map-bug.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__copy-texture-image-luma-format.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__copy-texture-image-same-texture.html]
 subsuite = webgl2-core
 skip-if = (os == 'win')
-fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__copy-texture-image-webgl-specific.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__copy-texture-image.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__generate-mipmap-with-large-base-level.html]
 subsuite = webgl2-core
-fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__gl-get-tex-parameter.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__integer-cubemap-specification-order-bug.html]
 subsuite = webgl2-core
-fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__integer-cubemap-texture-sampling.html]
 subsuite = webgl2-core
-fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__mipmap-fbo.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__npot-video-sizing.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__origin-clean-conformance-offscreencanvas.html]
 subsuite = webgl2-core
 skip-if = 1
 [generated/test_2_conformance2__textures__misc__tex-3d-mipmap-levels-intel-bug.html]
 subsuite = webgl2-core
-fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__tex-3d-size-limit.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__tex-base-level-bug.html]
 subsuite = webgl2-core
+fail-if = os == 'mac' && os_version == '10.14' # macosx1014 due to 1563418
 [generated/test_2_conformance2__textures__misc__tex-image-and-sub-image-with-array-buffer-view-sub-source.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__tex-image-with-bad-args-from-dom-elements.html]
 subsuite = webgl2-core
 skip-if = (os == 'win') || (os == 'mac')
 [generated/test_2_conformance2__textures__misc__tex-image-with-bad-args.html]
 subsuite = webgl2-core
 [generated/test_2_conformance2__textures__misc__tex-image-with-different-data-source.html]
--- a/dom/canvas/test/webgl-conf/mochitest-errata.ini
+++ b/dom/canvas/test/webgl-conf/mochitest-errata.ini
@@ -169,16 +169,18 @@ fail-if = 1
 fail-if = 1
 [generated/test_2_conformance2__textures__svg_image__tex-3d-rgb10_a2-rgba-unsigned_int_2_10_10_10_rev.html]
 fail-if = 1
 [generated/test_2_conformance2__textures__video__tex-2d-rgb10_a2-rgba-unsigned_int_2_10_10_10_rev.html]
 fail-if = 1
 [generated/test_2_conformance2__textures__video__tex-3d-rgb10_a2-rgba-unsigned_int_2_10_10_10_rev.html]
 fail-if = 1
 
+[generated/test_2_conformance2__textures__misc__tex-base-level-bug.html]
+fail-if = os == 'mac' && os_version == '10.14' # macosx1014 due to 1563418
 [generated/test_2_conformance2__textures__misc__tex-unpack-params-with-flip-y-and-premultiply-alpha.html]
 fail-if = 1
 
 ########################################################################
 # Complicated
 
 [generated/test_conformance__context__context-attributes-alpha-depth-stencil-antialias.html]
 # Asserts on linux debug. Crashes on Android.
@@ -268,17 +270,16 @@ skip-if = (os == 'linux') || (os == 'and
 skip-if = (os == 'android')
 [generated/test_2_conformance2__textures__misc__tex-image-with-bad-args-from-dom-elements.html]
 skip-if = (os == 'win') || (os == 'mac')
 [generated/test_2_conformance2__glsl3__tricky-loop-conditions.html]
 fail-if = (os == 'win')
 [generated/test_2_conformance2__rendering__blitframebuffer-outside-readbuffer.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__integer-cubemap-specification-order-bug.html]
-fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__tex-srgb-mipmap.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__video__tex-3d-r11f_g11f_b10f-rgb-float.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__video__tex-3d-r11f_g11f_b10f-rgb-half_float.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__video__tex-3d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev.html]
 fail-if = (os == 'mac')
@@ -335,17 +336,16 @@ fail-if = (os == 'mac')
 
 [generated/test_2_conformance2__textures__webgl_canvas__tex-2d-rgb10_a2-rgba-unsigned_int_2_10_10_10_rev.html]
 fail-if = (os == 'mac') || (os == 'win')
 [generated/test_2_conformance2__textures__webgl_canvas__tex-3d-rgb10_a2-rgba-unsigned_int_2_10_10_10_rev.html]
 fail-if = (os == 'mac') || (os == 'win')
 
 [generated/test_2_conformance2__textures__misc__copy-texture-image-same-texture.html]
 skip-if = (os == 'win')
-fail-if = (os == 'mac')
 
 [generated/test_conformance__rendering__rendering-stencil-large-viewport.html]
 fail-if = (os == 'mac') || (verify && debug && (os == 'linux'))
 # 02:52:43     INFO -  GECKO(1000) | JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conf/checkout/conformance/rendering/rendering-stencil-large-viewport.html, line 85: Error: WebGL warning: Requested size 32767x32767 was too large, but resize to 16383x16383 succeeded.
 # 02:52:43     INFO -  GECKO(1000) | JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conf/checkout/conformance/rendering/rendering-stencil-large-viewport.html, line 85: Error: WebGL warning: drawArrays: Drawing to a destination rect smaller than the viewport rect. (This warning will only be given once)
 # 02:52:43     INFO -  GECKO(1000) | MEMORY STAT | vsize 945MB | vsizeMaxContiguous 98MB | residentFast 211MB | heapAllocated 42MB
 # 02:52:43     INFO -  GECKO(1000) | ERR: rx::SwapChain11::resetOffscreenColorBuffer(268): Could not create offscreen texture, 0x0505
 # 02:52:43     INFO -  GECKO(1000) | JavaScript warning: , line 0: Error: WebGL warning: screen->Resize failed. Losing context.
@@ -641,32 +641,31 @@ skip-if = (os == 'mac')
 [generated/test_conformance__rendering__multisample-corruption.html]
 # application crashed [@ gldAttachDrawable + 0x9e0]. Also crash on Android.
 skip-if = (os == 'mac') || (os == 'android') || (os == 'win')
 [generated/test_2_conformance__textures__misc__copy-tex-image-2d-formats.html]
 # Assertion: ""GFX: We should have caught all other errors"" in WebGLTextureUpload.cpp
 skip-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__generate-mipmap-with-large-base-level.html]
 # getError expected: NO_ERROR. Was OUT_OF_MEMORY
-fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__tex-unpack-params-imagedata.html]
 # areArraysEqual(actual, expected) should be true. Was false.
 fail-if = (os == 'mac')
 
 ####################
 # failure on OSX
 [generated/test_2_conformance2__renderbuffers__multisampled-depth-renderbuffer-initialization.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__tex-unpack-params.html]
 skip-if = (os == 'mac' && debug)
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__glsl3__valid-invariant.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__reading__format-r11f-g11f-b10f.html]
-fail-if = (os == 'mac') || (os == "win" && processor == "aarch64") #aarch64 due to bug 1536182
+fail-if = (os == "win" && processor == "aarch64") #aarch64 due to bug 1536182
 [generated/test_2_conformance2__rendering__blitframebuffer-filter-outofbounds.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__rendering__blitframebuffer-filter-srgb.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__canvas_sub_rectangle__tex-3d-r11f_g11f_b10f-rgb-float.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__canvas_sub_rectangle__tex-3d-r11f_g11f_b10f-rgb-half_float.html]
 fail-if = (os == 'mac')
@@ -800,17 +799,16 @@ fail-if = (os == 'mac')
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__image_data__tex-2d-rg8ui-rg_integer-unsigned_byte.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__image_data__tex-2d-rgb8ui-rgb_integer-unsigned_byte.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__image_data__tex-2d-rgba8ui-rgba_integer-unsigned_byte.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__integer-cubemap-texture-sampling.html]
-fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__misc__tex-mipmap-levels.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__video__tex-3d-r16f-red-float.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__video__tex-3d-r16f-red-half_float.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance2__textures__video__tex-3d-r32f-red-float.html]
 fail-if = (os == 'mac')
@@ -889,17 +887,16 @@ fail-if = (os == 'mac')
 [generated/test_2_conformance__textures__webgl_canvas__tex-2d-alpha-alpha-unsigned_byte.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance__textures__webgl_canvas__tex-2d-luminance-luminance-unsigned_byte.html]
 fail-if = (os == 'mac')
 [generated/test_2_conformance__textures__webgl_canvas__tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html]
 fail-if = (os == 'mac')
 
 [generated/test_2_conformance2__textures__misc__tex-3d-mipmap-levels-intel-bug.html]
-fail-if = (os == 'mac')
 
 [generated/test_2_conformance2__extensions__ext-color-buffer-float.html]
 skip-if = (os == 'mac' && debug)
 [generated/test_2_conformance__limits__gl-line-width.html]
 skip-if = (os == 'mac')
 [generated/test_2_conformance__misc__type-conversion-test.html]
 skip-if = (os == 'mac' && debug)
 
--- a/taskcluster/ci/test/test-sets.yml
+++ b/taskcluster/ci/test/test-sets.yml
@@ -323,17 +323,17 @@ macosx1014-64-tests:
     # - mochitest-chrome
     - mochitest-devtools-chrome
     - mochitest-devtools-webreplay
     - mochitest-gpu
     - mochitest-media
     - mochitest-remote
     - mochitest-webgl1-core
     - mochitest-webgl1-ext
-    # - mochitest-webgl2-core
+    - mochitest-webgl2-core
     # - mochitest-webgl2-ext test  # timeouts
     - reftest
     - telemetry-tests-client
     - test-verify
     - test-verify-gpu
     - test-verify-wpt
     - web-platform-tests
     - web-platform-tests-reftests
@@ -344,17 +344,16 @@ macosx1014-64-qr-tests:
     - crashtest
     - reftest
 
 macosx64-tests:
     - gtest
     - mochitest-browser-chrome
     - mochitest-chrome
     - mochitest-media
-    - mochitest-webgl2-core
     # - mochitest-webgl2-ext test timeouts
 
 macosx64-talos:
     - talos-bcv
     - talos-chrome
     - talos-damp
     - talos-dromaeojs
     - talos-g1