Bug 1579516 - Remove XUL grid from browser/components/preferences/languages.xul. r=jaws
authorTim Nguyen <ntim.bugs@gmail.com>
Mon, 30 Sep 2019 16:06:26 +0000
changeset 496234 aefedc124f9a4ad6598a6757fe0e3c5c688efa06
parent 496233 922881dd399a94bda9635be2745af79fa8878238
child 496235 1c345279dea69932145825a48642d089b21967b7
push id36647
push usernerli@mozilla.com
push dateFri, 04 Oct 2019 04:09:18 +0000
treeherdermozilla-central@678d4d2c3c4d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1579516
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1579516 - Remove XUL grid from browser/components/preferences/languages.xul. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D45076
browser/components/preferences/languages.xul
browser/themes/shared/incontentprefs/preferences.inc.css
--- a/browser/components/preferences/languages.xul
+++ b/browser/components/preferences/languages.xul
@@ -33,44 +33,34 @@
   <stringbundleset id="languageSet">
     <stringbundle id="bundleAccepted"     src="resource://gre/res/language.properties"/>
   </stringbundleset>
 
   <description data-l10n-id="languages-description"/>
   <checkbox id="spoofEnglish"
             data-l10n-id="languages-customize-spoof-english"
             preference="privacy.spoof_english"/>
-  <grid flex="1">
-    <columns>
-      <column flex="1"/>
-      <column/>
-    </columns>
-    <rows>
-      <row flex="1">
-        <richlistbox id="activeLanguages" flex="1"
-                     seltype="multiple"
-                     onselect="gLanguagesDialog.onLanguageSelect();"/>
-        <vbox>
-          <button id="up" class="up" oncommand="gLanguagesDialog.moveUp();" disabled="true"
-                  data-l10n-id="languages-customize-moveup"
-                  preference="pref.browser.language.disable_button.up"/>
-          <button id="down" class="down" oncommand="gLanguagesDialog.moveDown();" disabled="true"
-                  data-l10n-id="languages-customize-movedown"
-                  preference="pref.browser.language.disable_button.down"/>
-          <button id="remove" oncommand="gLanguagesDialog.removeLanguage();" disabled="true"
-                  data-l10n-id="languages-customize-remove"
-                  preference="pref.browser.language.disable_button.remove"/>
-        </vbox>
-      </row>
-      <row>
-        <!-- This <vbox> is needed to position search tooltips correctly. -->
-        <vbox>
-          <menulist id="availableLanguages" oncommand="gLanguagesDialog.onAvailableLanguageSelect();"
-                    data-l10n-id="languages-customize-select-language" data-l10n-attrs="placeholder">
-            <menupopup id="availableLanguagesPopup"/>
-          </menulist>
-        </vbox>
-        <button id="addButton" class="add-web-language" oncommand="gLanguagesDialog.addLanguage();" disabled="true"
-                data-l10n-id="languages-customize-add"/>
-      </row>
-    </rows>
-  </grid>
+  <box flex="1" style="display: grid; grid-template-rows: 1fr auto; grid-template-columns: 1fr auto;">
+    <richlistbox id="activeLanguages"
+                 seltype="multiple"
+                 onselect="gLanguagesDialog.onLanguageSelect();"/>
+    <vbox>
+      <button id="up" class="up" oncommand="gLanguagesDialog.moveUp();" disabled="true"
+              data-l10n-id="languages-customize-moveup"
+              preference="pref.browser.language.disable_button.up"/>
+      <button id="down" class="down" oncommand="gLanguagesDialog.moveDown();" disabled="true"
+              data-l10n-id="languages-customize-movedown"
+              preference="pref.browser.language.disable_button.down"/>
+      <button id="remove" oncommand="gLanguagesDialog.removeLanguage();" disabled="true"
+              data-l10n-id="languages-customize-remove"
+              preference="pref.browser.language.disable_button.remove"/>
+    </vbox>
+    <!-- This <vbox> is needed to position search tooltips correctly. -->
+    <vbox>
+      <menulist id="availableLanguages" oncommand="gLanguagesDialog.onAvailableLanguageSelect();"
+                data-l10n-id="languages-customize-select-language" data-l10n-attrs="placeholder">
+        <menupopup id="availableLanguagesPopup"/>
+      </menulist>
+    </vbox>
+    <button id="addButton" class="add-web-language" oncommand="gLanguagesDialog.addLanguage();" disabled="true"
+            data-l10n-id="languages-customize-add"/>
+  </box>
 </dialog>
--- a/browser/themes/shared/incontentprefs/preferences.inc.css
+++ b/browser/themes/shared/incontentprefs/preferences.inc.css
@@ -270,20 +270,16 @@ button > hbox > label {
 #getStarted {
   font-size: 90%;
 }
 
 #useDocumentColors {
   margin: 0;
 }
 
-#activeLanguages {
-  height: 16em;
-}
-
 #activeLanguages > richlistitem {
   padding: 0.3em;
 }
 
 #downloadFolder {
   -moz-box-flex: 1;
   margin-inline-start: 0;
   padding-inline-start: 30px;