Bug 1552328 - Add missing unregisterListener in GeckoViewProgress. r=droeh
☠☠ backed out by 55e45fc9d529 ☠ ☠
authorAgi Sferro <agi@sferro.dev>
Fri, 17 May 2019 04:11:29 +0000
changeset 474293 aee7bbc03bff773a8ce895d0bd58174f2f8aafa1
parent 474292 2f69f765ef513a61ad39b4fc2b294135cf514e98
child 474294 877ae9359a2774f9ccee1f68935b4e7194a5711e
push id36027
push usershindli@mozilla.com
push dateFri, 17 May 2019 16:24:38 +0000
treeherdermozilla-central@c94c54aff466 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdroeh
bugs1552328
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1552328 - Add missing unregisterListener in GeckoViewProgress. r=droeh Differential Revision: https://phabricator.services.mozilla.com/D31538
mobile/android/modules/geckoview/GeckoViewProgress.jsm
--- a/mobile/android/modules/geckoview/GeckoViewProgress.jsm
+++ b/mobile/android/modules/geckoview/GeckoViewProgress.jsm
@@ -164,16 +164,17 @@ class GeckoViewProgress extends GeckoVie
     debug `onDisable`;
 
     if (this.progressFilter) {
       this.progressFilter.removeProgressListener(this);
       this.browser.removeProgressListener(this.progressFilter);
     }
 
     Services.obs.removeObserver(this, "oop-frameloader-crashed");
+    this.unregisterListener("GeckoView:FlushSessionState");
   }
 
   onEvent(aEvent, aData, aCallback) {
     debug `onEvent: event=${aEvent}, data=${aData}`;
 
     switch (aEvent) {
       case "GeckoView:FlushSessionState":
         this.messageManager.sendAsyncMessage("GeckoView:FlushSessionState");