Bug 1466222 - We don't sign android in the repack task, so don't allow us to validate the signature either. r=catlee
authorJustin Wood <Callek@gmail.com>
Fri, 01 Jun 2018 23:45:17 -0400
changeset 421395 ade6417729f020def9c93db85845e2eec073a1ff
parent 421394 0238371ddc7519939c6bd0d3149db3a0a2ba237d
child 421396 026368e10f6b7575198739d563c9a5f6509a8fb7
push id34093
push useraiakab@mozilla.com
push dateTue, 05 Jun 2018 21:58:58 +0000
treeherdermozilla-central@da28b92efe6f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscatlee
bugs1466222
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1466222 - We don't sign android in the repack task, so don't allow us to validate the signature either. r=catlee for "Cleanup l10n mozharness config files." Differential Revision: https://phabricator.services.mozilla.com/D1514
testing/mozharness/scripts/mobile_l10n.py
--- a/testing/mozharness/scripts/mobile_l10n.py
+++ b/testing/mozharness/scripts/mobile_l10n.py
@@ -104,17 +104,16 @@ class MobileSingleLocale(LocalesMixin,
     def __init__(self, require_config_file=True):
         buildscript_kwargs = {
             'all_actions': [
                 "get-secrets",
                 "clone-locales",
                 "list-locales",
                 "setup",
                 "repack",
-                "validate-repacks-signed",
                 "upload-repacks",
                 "create-virtualenv",
                 "summary",
             ],
             'config': {
                 'virtualenv_modules': [
                     'requests==2.8.1',
                 ],
@@ -396,43 +395,16 @@ class MobileSingleLocale(LocalesMixin,
                                 halt_on_failure=False):
                 self.add_failure(locale, message="%s failed in make installers-%s!" %
                                  (locale, locale))
                 continue
             success_count += 1
         self.summarize_success_count(success_count, total_count,
                                      message="Repacked %d of %d binaries successfully.")
 
-    def validate_repacks_signed(self):
-        c = self.config
-        dirs = self.query_abs_dirs()
-        locales = self.query_locales()
-        base_package_name = self.query_base_package_name()
-        base_package_dir = os.path.join(dirs['abs_objdir'], 'dist')
-        repack_env = self.query_repack_env()
-        success_count = total_count = 0
-        for locale in locales:
-            total_count += 1
-            signed_path = os.path.join(base_package_dir,
-                                       base_package_name % {'locale': locale})
-            status = self.verify_android_signature(
-                signed_path,
-                script=c['signature_verification_script'],
-                env=repack_env,
-                key_alias=c['key_alias'],
-            )
-            if status:
-                self.add_failure(locale, message="Errors verifying %s binary!" % locale)
-                # No need to rm because upload is per-locale
-                continue
-            success_count += 1
-        self.summarize_success_count(success_count, total_count,
-                                     message="Validated signatures on %d of %d "
-                                             "binaries successfully.")
-
     def upload_repacks(self):
         dirs = self.query_abs_dirs()
         locales = self.query_locales()
         make = self.query_exe("make")
         base_package_name = self.query_base_package_name()
         upload_env = self.query_upload_env()
         success_count = total_count = 0
         for locale in locales: