Bug 1349905 - Make _beginRemoveTab consistently return a boolean. r=dao
authorHrishikesh Barman <hrishikeshbman@gmail.com>
Fri, 24 Mar 2017 19:14:16 +0530
changeset 349559 adb38e68486e
parent 349558 ddc2134eb603
child 349560 249037d28c78
push id31553
push userkwierso@gmail.com
push dateSat, 25 Mar 2017 00:17:38 +0000
treeherdermozilla-central@65b0ac174753 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1349905
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1349905 - Make _beginRemoveTab consistently return a boolean. r=dao
browser/base/content/tabbrowser.xml
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -2700,17 +2700,17 @@
               // than closing the window right away. If the caller opts in, take
               // the fast path.
               if (closeWindow &&
                   aCloseWindowFastpath &&
                   this._removingTabs.length == 0) {
                 // This call actually closes the window, unless the user
                 // cancels the operation.  We are finished here in both cases.
                 this._windowIsClosing = window.closeWindow(true, window.warnAboutClosingWindow);
-                return null;
+                return false;
               }
 
               newTab = true;
             }
 
             aTab.closing = true;
             this._removingTabs.push(aTab);
             this._visibleTabs = null; // invalidate cache