Bug 988826 - Using LongStringActor for exceptionMessage in the evaluateJS response packet. r=past
authorAkshendra Pratap <akshendra521994@gmail.com>
Fri, 14 Nov 2014 11:05:00 +0100
changeset 216444 ad98a5bdb2e1c8d5c78e42942ecce9685bc487b6
parent 216443 e0ac11eb4bf426201d02486d4ed5f66458f97583
child 216445 1c1aaebe93520f52ba2b261cd886869a8926d953
push id27850
push usercbook@mozilla.com
push dateWed, 19 Nov 2014 12:44:14 +0000
treeherdermozilla-central@aa72ddfe9f93 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspast
bugs988826
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 988826 - Using LongStringActor for exceptionMessage in the evaluateJS response packet. r=past
toolkit/devtools/server/actors/webconsole.js
toolkit/devtools/webconsole/test/test_throw.html
--- a/toolkit/devtools/server/actors/webconsole.js
+++ b/toolkit/devtools/server/actors/webconsole.js
@@ -782,17 +782,17 @@ WebConsoleActor.prototype =
     }
 
     return {
       from: this.actorID,
       input: input,
       result: resultGrip,
       timestamp: timestamp,
       exception: errorGrip,
-      exceptionMessage: errorMessage,
+      exceptionMessage: this._createStringGrip(errorMessage),
       helperResult: helperResult,
     };
   },
 
   /**
    * The Autocomplete request handler.
    *
    * @param object aRequest
--- a/toolkit/devtools/webconsole/test/test_throw.html
+++ b/toolkit/devtools/webconsole/test/test_throw.html
@@ -50,16 +50,19 @@ function onAttach(aState, aResponse)
       shortedString = longString.substring(0,
                         DebuggerServer.LONG_STRING_INITIAL_LENGTH
                       );
   tests.push(function() {
     aState.client.evaluateJS("throw '" + longString + "';", function(aResponse) {
       is(aResponse.exception.initial, shortedString,
         "exception.initial for throw longString"
       );
+      is(aResponse.exceptionMessage.initial, shortedString,
+        "exceptionMessage.initial for throw longString"
+      );
       nextTest();
     });
   });
 
   runTests(tests, endTest.bind(null, aState));
 }
 
 function endTest(aState)