Bug 1594979 - Logpoints fail to log with `frame is null`. r=bhackett
authorJason Laster <jlaster@mozilla.com>
Fri, 08 Nov 2019 16:49:11 +0000
changeset 501336 acfd160d39982d163d7fddbee91e79bf221841b9
parent 501335 2ce8f24176dd2f040f2e3be487696ab415399abc
child 501337 0516cc76b5b20ede18eafb873a289d7ababa905a
push id36785
push userccoroiu@mozilla.com
push dateSat, 09 Nov 2019 09:37:18 +0000
treeherdermozilla-central@caf55914ccdd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbhackett
bugs1594979
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1594979 - Logpoints fail to log with `frame is null`. r=bhackett Differential Revision: https://phabricator.services.mozilla.com/D52310
devtools/client/webconsole/utils/messages.js
--- a/devtools/client/webconsole/utils/messages.js
+++ b/devtools/client/webconsole/utils/messages.js
@@ -239,17 +239,17 @@ function transformConsoleAPICallPacket(p
     ? {
         source: message.filename,
         sourceId: message.sourceId,
         line: message.lineNumber,
         column: message.columnNumber,
       }
     : null;
 
-  if (type === "logPointError" || type === "logPoint") {
+  if (frame && (type === "logPointError" || type === "logPoint")) {
     frame.options = { logPoint: true };
   }
 
   return new ConsoleMessage({
     source: MESSAGE_SOURCE.CONSOLE_API,
     type,
     level,
     parameters,