Bug 1444531 [wpt PR 9951] - Document we wait for web fonts in reftests, a=testonly
authorRobert Ma <bob1211@gmail.com>
Mon, 26 Mar 2018 15:41:19 +0000
changeset 411287 ac0dc43b4fc03dcffcb4047d25d1f0f2a960474e
parent 411286 907707ea82102cf5de55d498405b7088b1d8c6d3
child 411288 1bf5b6bb6a0e362198c1708bd8de1109699d664e
push id33749
push usercsabou@mozilla.com
push dateMon, 02 Apr 2018 10:18:51 +0000
treeherdermozilla-central@c44f60c43432 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1444531
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1444531 [wpt PR 9951] - Document we wait for web fonts in reftests, a=testonly Automatic update from web-platform-testsDocument that we wait for web fonts in reftests (#9951) wpt-commits: 90d610bab706930b9159572b2c98e5389ff4b189 wpt-pr: 9951 wpt-commits: 90d610bab706930b9159572b2c98e5389ff4b189 wpt-pr: 9951
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/docs/_writing-tests/reftests.md
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -543926,17 +543926,17 @@
    "96cf62f747c7367e81c6001831bd3f22ae62f0fa",
    "support"
   ],
   "docs/_writing-tests/manual.md": [
    "2c2ba2b257c7705a5b1f98f259fc0bc5df4bce17",
    "support"
   ],
   "docs/_writing-tests/reftests.md": [
-   "19c5c75eb5d2a09f8ba61f94900f4e80a2d6b1bf",
+   "e9008d9896ba0693352309e2d16353b8bd16874f",
    "support"
   ],
   "docs/_writing-tests/rendering.md": [
    "ec1533df5a1bc5a13b9ceaac1265c0784ccd0a27",
    "support"
   ],
   "docs/_writing-tests/server-features.md": [
    "c9ed5970c091c7fe7aa16847b8c68783b133a25a",
--- a/testing/web-platform/tests/docs/_writing-tests/reftests.md
+++ b/testing/web-platform/tests/docs/_writing-tests/reftests.md
@@ -94,24 +94,25 @@ In this case, to pass we must either hav
 `b1.html` all rendering identically, or `a.html` and `c.html`
 rendering identically with `c1.html` rendering differently. (These
 are, in terms of the graph, all the paths from the source nodes to
 leaf nodes.)
 
 ## Controlling When Comparison Occurs
 
 By default reftest screenshots are taken after the `load` event has
-fired. In some cases it is necessary to delay the screenshot later
-than this, for example because some DOM manipulation is required to
-set up the desired test conditions. To enable this, the test may have
-a `class="reftest-wait"` attribute specified on the root element. This
-will cause the screenshot to be delayed until the `load` event has
-fired and the `reftest-wait` class has been removed from the root
-element. Note that in neither case is exact timing of the screenshot
-guaranteed: it is only guaranteed to be after those events.
+fired, and web fonts (if any) are loaded. In some cases it is
+necessary to delay the screenshot later than this, for example because
+some DOM manipulation is required to set up the desired test
+conditions. To enable this, the test may have a `class="reftest-wait"`
+attribute specified on the root element. This will cause the
+screenshot to be delayed until the `load` event has fired and the
+`reftest-wait` class has been removed from the root element. Note that
+in neither case is exact timing of the screenshot guaranteed: it is
+only guaranteed to be after those events.
 
 ## Fuzzy Matching
 
 In some situations a test may have subtle differences in rendering
 compared to the reference due to, e.g., anti-aliasing. This may cause
 the test to pass on some platforms but fail on others. In this case
 some affordance for subtle discrepancies is desirable. However no
 mechanism to allow this has yet been standardized.