Bug 1577504 - Remove redundant closures r=jgraham
authorDavid Heiberg <dheiberg@mozilla.com>
Tue, 10 Sep 2019 15:02:27 +0000
changeset 492512 abda0958db89df7fed0a30476de200a532373ba3
parent 492511 ed5978118f064f37f84a5bbf1a4c9c984519aad9
child 492513 cc25750fd9e8b0015f6a693f87d87b2fc3e0a29d
push id36559
push useropoprus@mozilla.com
push dateTue, 10 Sep 2019 21:39:50 +0000
treeherdermozilla-central@0e0e9c22321e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjgraham
bugs1577504
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1577504 - Remove redundant closures r=jgraham Depends on D45356 Differential Revision: https://phabricator.services.mozilla.com/D45357
testing/mozbase/rust/mozrunner/src/runner.rs
--- a/testing/mozbase/rust/mozrunner/src/runner.rs
+++ b/testing/mozbase/rust/mozrunner/src/runner.rs
@@ -252,18 +252,18 @@ impl Runner for FirefoxRunner {
     {
         self.stderr = Some(stderr.into());
         self
     }
 
     fn start(mut self) -> Result<FirefoxProcess, RunnerError> {
         self.profile.user_prefs()?.write()?;
 
-        let stdout = self.stdout.unwrap_or_else(|| Stdio::inherit());
-        let stderr = self.stderr.unwrap_or_else(|| Stdio::inherit());
+        let stdout = self.stdout.unwrap_or_else(Stdio::inherit);
+        let stderr = self.stderr.unwrap_or_else(Stdio::inherit);
 
         let binary_path = platform::resolve_binary_path(&mut self.path);
         let mut cmd = Command::new(binary_path);
         cmd.args(&self.args[..])
             .envs(&self.envs)
             .stdout(stdout)
             .stderr(stderr);