Bug 1459270 - fixed a regression where IPC was not correctly checking for transitions to actors being dead; r=froydnj
authorAlex Gaynor <agaynor@mozilla.com>
Fri, 04 May 2018 13:51:22 -0400
changeset 416994 abb42d44a7242dc32cb94d955962100305e586ed
parent 416993 a9c753c1bb5d88dcbb666a9eb0a3ad2e2499c72e
child 416995 a761c0e32512b44c1bc250bae308bc44a2480294
push id33948
push userncsoregi@mozilla.com
push dateSat, 05 May 2018 09:49:52 +0000
treeherdermozilla-central@51d020e4c2cb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1459270
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1459270 - fixed a regression where IPC was not correctly checking for transitions to actors being dead; r=froydnj MozReview-Commit-ID: HzhUna0mVpB
ipc/ipdl/ipdl/lower.py
--- a/ipc/ipdl/ipdl/lower.py
+++ b/ipc/ipdl/ipdl/lower.py
@@ -4628,17 +4628,17 @@ class _GenerateProtocolActorCode(ipdl.as
             # avoid unused-variable warnings
             saveIdStmts = [ StmtDecl(Decl(_actorIdType(), idvar.name),
                                      self.protocol.routingId()) ]
         else:
             saveIdStmts = [ ]
         return idvar, saveIdStmts
 
     def transition(self, md, actor=None, reply=False, errorfn=None):
-        msgid = md.pqMsgId() if not reply else md.pqReplyId()
+        msgid = md.msgId() if not reply else md.replyId()
         args = [
             ExprVar('true' if _deleteId().name == msgid else 'false'),
         ]
         if self.protocol.decl.type.hasReentrantDelete:
             function = 'ReEntrantDeleteStateTransition'
             args.append(
                 ExprVar('true' if _deleteReplyId().name == msgid else 'false'),
             )