Bug 1517988 Insert a placeholder name for addons if necessary in about:support r=Standard8
authorAndrew Swan <aswan@mozilla.com>
Fri, 11 Jan 2019 11:39:04 +0000
changeset 453515 ab971e61cf793a8a7ed3918aa2a86724fbbb4cde
parent 453514 0a9c477577dec9ab7b8f4bf6e424e1c19f4db256
child 453516 b5b1f341206d87c70036b2f35f8ae9604e29535f
push id35357
push usernerli@mozilla.com
push dateFri, 11 Jan 2019 21:54:07 +0000
treeherdermozilla-central@0ce024c91511 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersStandard8
bugs1517988
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1517988 Insert a placeholder name for addons if necessary in about:support r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D16133
toolkit/modules/Troubleshoot.jsm
--- a/toolkit/modules/Troubleshoot.jsm
+++ b/toolkit/modules/Troubleshoot.jsm
@@ -232,18 +232,18 @@ var dataProviders = {
   extensions: async function extensions(done) {
     let extensions = await AddonManager.getAddonsByTypes(["extension"]);
     extensions = extensions.filter(e => !e.isSystem);
     extensions.sort(function(a, b) {
       if (a.isActive != b.isActive)
         return b.isActive ? 1 : -1;
 
       // In some unfortunate cases addon names can be null.
-      let aname = a.name || null;
-      let bname = b.name || null;
+      let aname = a.name || "";
+      let bname = b.name || "";
       let lc = aname.localeCompare(bname);
       if (lc != 0)
         return lc;
       if (a.version != b.version)
         return a.version > b.version ? 1 : -1;
       return 0;
     });
     let props = ["name", "version", "isActive", "id"];