Bug 940765 - pref_HashTableLookup cannot GC, r=terrence
authorSteve Fink <sfink@mozilla.com>
Tue, 19 Nov 2013 23:22:54 -0800
changeset 156636 ab8b9448e062b898cb5542f80d283e8ef1040b25
parent 156635 972924aa711072a0bd6ee233fd242d3245d2a110
child 156637 c9d2dcea4480f4d72421db289fe69f54f3bb4010
push id25684
push usercbook@mozilla.com
push dateThu, 21 Nov 2013 13:21:05 +0000
treeherdermozilla-central@7427eede548f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersterrence
bugs940765
milestone28.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 940765 - pref_HashTableLookup cannot GC, r=terrence DONTBUILD because this only affects the analysis, and that'll get rebuilt soon enough
js/src/devtools/rootAnalysis/annotations.js
--- a/js/src/devtools/rootAnalysis/annotations.js
+++ b/js/src/devtools/rootAnalysis/annotations.js
@@ -155,16 +155,19 @@ var ignoreFunctions = {
     "NS_LogCtor": true,
     "NS_LogDtor": true,
     "NS_LogCOMPtrAddRef": true,
     "NS_LogCOMPtrRelease": true,
 
     // FIXME!
     "NS_DebugBreak": true,
 
+    // Bug 940765 - fetching preferences should not GC
+    "PrefHashEntry* pref_HashTableLookup(void*)": true,
+
     // These are a little overzealous -- these destructors *can* GC if they end
     // up wrapping a pending exception. See bug 898815 for the heavyweight fix.
     "void js::AutoCompartment::~AutoCompartment(int32)" : true,
     "void JSAutoCompartment::~JSAutoCompartment(int32)" : true,
 
     // And these are workarounds to avoid even more analysis work,
     // which would sadly still be needed even with bug 898815.
     "void js::AutoCompartment::AutoCompartment(js::ExclusiveContext*, JSCompartment*)": true,