Bug 1456394 - Make TimingParameters::operator== compare end delay values; r=hiro
authorBrian Birtles <birtles@gmail.com>
Mon, 07 May 2018 12:42:24 +0900
changeset 417850 ab4634b0c0b723886ecd263fdfd33c3354698717
parent 417849 ea71864d99b4836a7934e75b61e0c84e4863a649
child 417851 0ab592b16b0417e9f170a4494f7a47b5593b43a3
push id33980
push userebalazs@mozilla.com
push dateFri, 11 May 2018 09:35:12 +0000
treeherdermozilla-central@8e9a4a323f0c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershiro
bugs1456394
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1456394 - Make TimingParameters::operator== compare end delay values; r=hiro MozReview-Commit-ID: 5frk5APUTDd
dom/animation/TimingParams.cpp
testing/web-platform/meta/web-animations/interfaces/Animatable/getAnimations.html.ini
testing/web-platform/meta/web-animations/interfaces/AnimationEffect/updateTiming.html.ini
--- a/dom/animation/TimingParams.cpp
+++ b/dom/animation/TimingParams.cpp
@@ -224,16 +224,17 @@ TimingParams::ParseEasing(const nsAStrin
 
 bool
 TimingParams::operator==(const TimingParams& aOther) const
 {
   // We don't compare mActiveDuration and mEndTime because they are calculated
   // from other timing parameters.
   return mDuration == aOther.mDuration &&
          mDelay == aOther.mDelay &&
+         mEndDelay == aOther.mEndDelay &&
          mIterations == aOther.mIterations &&
          mIterationStart == aOther.mIterationStart &&
          mDirection == aOther.mDirection &&
          mFill == aOther.mFill &&
          mFunction == aOther.mFunction;
 }
 
 } // namespace mozilla
deleted file mode 100644
--- a/testing/web-platform/meta/web-animations/interfaces/Animatable/getAnimations.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[getAnimations.html]
-  [Returns animations based on dynamic changes to individual animations' end delay]
-    expected: FAIL
-
deleted file mode 100644
--- a/testing/web-platform/meta/web-animations/interfaces/AnimationEffect/updateTiming.html.ini
+++ /dev/null
@@ -1,7 +0,0 @@
-[updateTiming.html]
-  [Allows setting the endDelay to a positive number]
-    expected: FAIL
-
-  [Allows setting the endDelay to a negative number]
-    expected: FAIL
-