Bug 1257936 - TabsPanel: Do not hold static references to views. r=ahunt
authorSebastian Kaspari <s.kaspari@gmail.com>
Fri, 18 Mar 2016 20:09:32 +0100
changeset 289575 ab15d48afbb2a88b157b305ff93384f5fe6398d0
parent 289574 1ace0d75f8b7bc2d8fccca13cca33966e7464ca0
child 289576 116497ecbdabb62e985e99fc15e9f05814482c94
push id30107
push usercbook@mozilla.com
push dateTue, 22 Mar 2016 10:00:23 +0000
treeherdermozilla-central@3587b25bae30 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersahunt
bugs1257936
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1257936 - TabsPanel: Do not hold static references to views. r=ahunt MozReview-Commit-ID: F6srFGDG5wx
mobile/android/base/java/org/mozilla/gecko/tabs/TabsPanel.java
--- a/mobile/android/base/java/org/mozilla/gecko/tabs/TabsPanel.java
+++ b/mobile/android/base/java/org/mozilla/gecko/tabs/TabsPanel.java
@@ -84,18 +84,18 @@ public class TabsPanel extends LinearLay
     private RelativeLayout mHeader;
     private FrameLayout mTabsContainer;
     private PanelView mPanel;
     private PanelView mPanelNormal;
     private PanelView mPanelPrivate;
     private TabsLayoutChangeListener mLayoutChangeListener;
 
     private IconTabWidget mTabWidget;
-    private static View mMenuButton;
-    private static ImageButton mAddTab;
+    private View mMenuButton;
+    private ImageButton mAddTab;
     private ImageButton mNavBackButton;
 
     private Panel mCurrentPanel;
     private boolean mVisible;
     private boolean mHeaderVisible;
 
     private final GeckoPopupMenu mPopupMenu;