Bug 1280796 - Selection cache should be updated on commit string. r=masayuki
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Tue, 28 Jun 2016 10:28:42 +0900
changeset 302823 aa7f5f55af9475431e200556681cca08a582c97f
parent 302822 74ed3becf2d2b00f46ca48627f0badb3bc93ba4c
child 302824 e30eb329b1320c54228eb5fd5a6f4246f0558241
push id30376
push usercbook@mozilla.com
push dateTue, 28 Jun 2016 14:09:36 +0000
treeherdermozilla-central@e45890951ce7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmasayuki
bugs1280796
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1280796 - Selection cache should be updated on commit string. r=masayuki Selection cache might be updated on commit string, so it should be updated correctly. Also, IMContextWrapper::OnSelectionChange() already has the check for composing using IsComposing(). MozReview-Commit-ID: 2n3f3I3aAjg
widget/gtk/IMContextWrapper.cpp
--- a/widget/gtk/IMContextWrapper.cpp
+++ b/widget/gtk/IMContextWrapper.cpp
@@ -334,20 +334,16 @@ IMContextWrapper::GetIMEUpdatePreference
 
     nsIMEUpdatePreference::Notifications notifications =
         nsIMEUpdatePreference::NOTIFY_SELECTION_CHANGE;
     // If it's not enabled, we don't need position change notification.
     if (IsEnabled()) {
         notifications |= nsIMEUpdatePreference::NOTIFY_POSITION_CHANGE;
     }
     nsIMEUpdatePreference updatePreference(notifications);
-    // We shouldn't notify IME of selection change caused by changes of
-    // composition string.  Therefore, we don't need to be notified selection
-    // changes which are caused by compositionchange events handled.
-    updatePreference.DontNotifyChangesCausedByComposition();
     return updatePreference;
 }
 
 void
 IMContextWrapper::OnDestroyWindow(nsWindow* aWindow)
 {
     MOZ_LOG(gGtkIMLog, LogLevel::Info,
         ("GTKIM: %p OnDestroyWindow(aWindow=%p), mLastFocusedWindow=%p, "