Bug 1297474 - clean up internal accessible when xpcAccessibleApplication is being destroyed. r=surkov
authorYura Zenevich <yzenevich@mozilla.com>
Mon, 21 Nov 2016 11:38:21 -0500
changeset 323813 a9f041fdef8821a63acbbe4b81542b135b5438e8
parent 323812 b31503980044f99045a05c3227cdc0e8151505d2
child 323814 ddc9b2697068639ae1980c6753f79578301eedf6
push id30983
push userphilringnalda@gmail.com
push dateWed, 23 Nov 2016 04:03:17 +0000
treeherdermozilla-central@0ddfec7126ec [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssurkov
bugs1297474
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1297474 - clean up internal accessible when xpcAccessibleApplication is being destroyed. r=surkov MozReview-Commit-ID: GuHEdhpJDx7
accessible/xpcom/xpcAccessibleApplication.h
--- a/accessible/xpcom/xpcAccessibleApplication.h
+++ b/accessible/xpcom/xpcAccessibleApplication.h
@@ -28,17 +28,20 @@ public:
 
   // nsIAccessibleApplication
   NS_IMETHOD GetAppName(nsAString& aName) final override;
   NS_IMETHOD GetAppVersion(nsAString& aVersion) final override;
   NS_IMETHOD GetPlatformName(nsAString& aName) final override;
   NS_IMETHOD GetPlatformVersion(nsAString& aVersion) final override;
 
 protected:
-  virtual ~xpcAccessibleApplication() {}
+  virtual ~xpcAccessibleApplication()
+  {
+    Shutdown();
+  }
 
 private:
   ApplicationAccessible* Intl() { return mIntl.AsAccessible()->AsApplication(); }
 
   xpcAccessibleApplication(const xpcAccessibleApplication&) = delete;
   xpcAccessibleApplication& operator =(const xpcAccessibleApplication&) = delete;
 };