Bug 1257413 - Fix check_prog() to properly fail when program is missing after bug 1256568. r=gps
authorMike Hommey <mh+mozilla@glandium.org>
Thu, 17 Mar 2016 12:55:37 +0900
changeset 289126 a989025d727f70b7c0a709e5658d58ab0eb9ee4d
parent 289125 22b32ab5ce8f779b35b664d6114ab5cf5f9a9f77
child 289127 6604ad32c93fcaf780c8c413bbb2d9e0d3f246e8
push id30096
push usercbook@mozilla.com
push dateThu, 17 Mar 2016 10:00:34 +0000
treeherdermozilla-central@fefe2bc3e54f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps
bugs1257413, 1256568
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1257413 - Fix check_prog() to properly fail when program is missing after bug 1256568. r=gps
build/moz.configure/checks.configure
--- a/build/moz.configure/checks.configure
+++ b/build/moz.configure/checks.configure
@@ -64,14 +64,14 @@ def check_prog(var, progs, allow_missing
             if result:
                 return result
         return not_found
 
     @depends(check)
     @advanced
     def postcheck(value):
         set_config(var, ':' if value is not_found else value)
-        if not value and not allow_missing:
+        if value is not_found and not allow_missing:
             from mozbuild.shellutil import quote
             error('Cannot find %s (tried: %s)'
                   % (var.lower(), ', '.join(quote(p) for p in progs)))
 
     return check