Bug 1513567 - fix version compare for browser error tests, r=aryx
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Fri, 14 Dec 2018 20:41:21 +0000
changeset 450577 a743dea491c904fa89cb0f3a3a3b5945ed4330bd
parent 450576 b1a9da82d2be81e5c61c694035948e0802978889
child 450578 2286c129387080cc0bb809158d3c38d8ccff7bfa
push id35207
push useraciure@mozilla.com
push dateSat, 15 Dec 2018 02:27:37 +0000
treeherdermozilla-central@d8a944c012a7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaryx
bugs1513567
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1513567 - fix version compare for browser error tests, r=aryx Differential Revision: https://phabricator.services.mozilla.com/D14606
browser/modules/test/browser/head_BrowserErrorReporter.js
--- a/browser/modules/test/browser/head_BrowserErrorReporter.js
+++ b/browser/modules/test/browser/head_BrowserErrorReporter.js
@@ -17,17 +17,17 @@ const TELEMETRY_ERROR_COLLECTED = "brows
 const TELEMETRY_ERROR_COLLECTED_FILENAME = "browser.errors.collected_count_by_filename";
 const TELEMETRY_ERROR_COLLECTED_STACK = "browser.errors.collected_with_stack_count";
 const TELEMETRY_ERROR_REPORTED = "browser.errors.reported_success_count";
 const TELEMETRY_ERROR_REPORTED_FAIL = "browser.errors.reported_failure_count";
 const TELEMETRY_ERROR_SAMPLE_RATE = "browser.errors.sample_rate";
 
 const currentVersion = Services.appinfo.platformVersion;
 const expiringVersion = "64.0";
-const SCALARS_EXPIRED = Services.vc.compare(currentVersion, expiringVersion) === -1;
+const SCALARS_EXPIRED = Services.vc.compare(currentVersion, expiringVersion) === 1;
 
 add_task(async function testSetup() {
   const canRecordExtended = Services.telemetry.canRecordExtended;
   Services.telemetry.canRecordExtended = true;
   registerCleanupFunction(() => Services.telemetry.canRecordExtended = canRecordExtended);
 });
 
 function createScriptError(options = {}) {