Backed out changeset 996f7985ca6b (bug 1430141) for reftests/writing-mode/ua-style-sheet-input-number-1.html failures
authorBogdan Tara <btara@mozilla.com>
Wed, 15 Jan 2020 16:16:55 +0200
changeset 510353 a71328ffbea20d55bc9d2f34cba3aa68c242ee81
parent 510352 8a1dc2b6e1046d1fbb0b820664f2a1da71a4bf83
child 510354 f36ee6cabccd57f19708ebc275d198bc1a82d3b8
push id37020
push userccoroiu@mozilla.com
push dateWed, 15 Jan 2020 21:36:21 +0000
treeherdermozilla-central@c35bb210b8ae [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1430141
milestone74.0a1
backs out996f7985ca6b46feaf6fdf1a5fe9e84437c0e376
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 996f7985ca6b (bug 1430141) for reftests/writing-mode/ua-style-sheet-input-number-1.html failures
layout/reftests/forms/input/number/flex-ref.html
layout/reftests/forms/input/number/flex.html
layout/reftests/forms/input/number/reftest.list
layout/style/res/forms.css
deleted file mode 100644
--- a/layout/reftests/forms/input/number/flex-ref.html
+++ /dev/null
@@ -1,22 +0,0 @@
-<!doctype html>
-<style>
-  label {
-    padding: 2px 4px;
-    display: flex;
-    flex-flow: column;
-    background: #ddd;
-    overflow: hidden;
-    min-height: 0;
-    min-width: 0;
-    width: 80px;
-  }
-  input {
-    flex: 1 1 auto;
-    margin: 4px;
-    min-height: 0;
-    min-width: 0;
-  }
-</style>
-<label>
-  <input type="text">
-</label>
deleted file mode 100644
--- a/layout/reftests/forms/input/number/flex.html
+++ /dev/null
@@ -1,23 +0,0 @@
-<!doctype html>
-<style>
-  label {
-    padding: 2px 4px;
-    display: flex;
-    flex-flow: column;
-    background: #ddd;
-    overflow: hidden;
-    min-height: 0;
-    min-width: 0;
-    width: 80px;
-  }
-  input {
-    flex: 1 1 auto;
-    margin: 4px;
-    min-height: 0;
-    min-width: 0;
-    -moz-appearance: textfield;
-  }
-</style>
-<label>
-  <input type="number">
-</label>
--- a/layout/reftests/forms/input/number/reftest.list
+++ b/layout/reftests/forms/input/number/reftest.list
@@ -18,17 +18,16 @@ fuzzy-if(skiaContent,0-2,0-5) == from-nu
 # dynamic value changes:
 fuzzy-if(skiaContent,0-2,0-13) == show-value.html show-value-ref.html
 
 # disabled
 == number-disabled.html number-disabled-ref.html
 
 # auto width:
 == number-auto-width-1.html number-auto-width-1-ref.html
-== flex.html flex-ref.html
 
 # min-height/max-height tests:
 skip-if(Android) == number-min-height-1.html number-min-height-1-ref.html
 skip-if(Android) == number-min-height-2.html number-min-height-2-ref.html
 skip-if(Android) == number-max-height-1.html number-max-height-1-ref.html
 skip-if(Android) == number-max-height-2.html number-max-height-2-ref.html
 
 # number of significant fractional digits:
--- a/layout/style/res/forms.css
+++ b/layout/style/res/forms.css
@@ -974,16 +974,20 @@ input[type=range]::-moz-range-thumb {
   border-radius: 0.5em;
   background-color: #F0F0F0;
   /* Prevent nsFrame::HandlePress setting mouse capture to this element. */
   user-select: none !important;
 }
 
 input[type="number"] {
   -moz-appearance: number-input;
+  /* Has to revert some properties applied by the generic input rule. */
+  inline-size: 20ch; /* It'd be nice if this matched the default inline-size
+                        of <input type=text>, but that's not easy to achieve
+                        due to platform differences. */
 }
 
 input[type=number]::-moz-number-wrapper {
   /* Prevent styling that would change the type of frame we construct. */
   display: flex;
   float: none !important;
   position: static !important;
   block-size: 100%;