Backed out changeset b81ec733e5c2 (bug 1345606)
authorWes Kocher <wkocher@mozilla.com>
Thu, 09 Mar 2017 15:27:32 -0800
changeset 346856 a6a31be4591879b37d6c33a849958400819e8559
parent 346855 ac6e090b6365fc0c298c15e7dcd5a522b91fb145
child 346857 ee52a1c26048e4b8872589b98837f137e9d81567
push id31479
push userkwierso@gmail.com
push dateFri, 10 Mar 2017 00:33:39 +0000
treeherdermozilla-central@35398cae65c1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1345606
milestone55.0a1
backs outb81ec733e5c2df285e18825368567628ab16fccb
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset b81ec733e5c2 (bug 1345606) MozReview-Commit-ID: J8ecV1FShCR
dom/html/HTMLInputElement.cpp
dom/html/HTMLTextAreaElement.cpp
testing/web-platform/mozilla/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
--- a/dom/html/HTMLInputElement.cpp
+++ b/dom/html/HTMLInputElement.cpp
@@ -6315,19 +6315,17 @@ void
 HTMLInputElement::GetValueFromSetRangeText(nsAString& aValue)
 {
   GetNonFileValueInternal(aValue);
 }
 
 nsresult
 HTMLInputElement::SetValueFromSetRangeText(const nsAString& aValue)
 {
-  return SetValueInternal(aValue,
-                          nsTextEditorState::eSetValue_ByContent |
-                          nsTextEditorState::eSetValue_Notify);
+  return SetValueInternal(aValue, nsTextEditorState::eSetValue_ByContent);
 }
 
 Nullable<uint32_t>
 HTMLInputElement::GetSelectionStart(ErrorResult& aRv)
 {
   if (!SupportsTextSelection()) {
     return Nullable<uint32_t>();
   }
--- a/dom/html/HTMLTextAreaElement.cpp
+++ b/dom/html/HTMLTextAreaElement.cpp
@@ -779,19 +779,17 @@ void
 HTMLTextAreaElement::GetValueFromSetRangeText(nsAString& aValue)
 {
   GetValueInternal(aValue, false);
 }
 
 nsresult
 HTMLTextAreaElement::SetValueFromSetRangeText(const nsAString& aValue)
 {
-  return SetValueInternal(aValue,
-                          nsTextEditorState::eSetValue_ByContent |
-                          nsTextEditorState::eSetValue_Notify);
+  return SetValueInternal(aValue, nsTextEditorState::eSetValue_ByContent);
 }
 
 nsresult
 HTMLTextAreaElement::Reset()
 {
   nsAutoString resetVal;
   GetDefaultValue(resetVal);
   SetValueChanged(false);
--- a/testing/web-platform/mozilla/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
+++ b/testing/web-platform/mozilla/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
@@ -195,25 +195,9 @@ for (var data of elemData) {
       assert_equals(el.selectionStart, shorttext.length,
                     "Should have adjusted selection start");
       assert_equals(el.selectionEnd, shorttext.length,
                     "Should have adjusted selection end");
     }
   }, `selection location after defaultValue set to shorter than selectionStart of ${data.desc}`);
 }
 
-for (var data of elemData) {
-  test(function() {
-    var el = data.factory();
-    this.add_cleanup(() => el.remove());
-    el.defaultValue = sometext;
-    assert_true(sometext.length > 8,
-                "sometext too short, test won't work right");
-    el.selectionStart = 4;
-    el.selectionEnd = 6;
-    el.setRangeText("xyz");
-    el.defaultValue = "set range text";
-    assert_equals(el.value, sometext.slice(0, 4) + "xyz" + sometext.slice(6),
-                  "Calling setRangeText should set the value dirty flag");
-  }, `value dirty flag behavior after setRangeText on ${data.desc}`);
-}
-
 </script>