Bug 1361463 - Fix typo in BrowserAction.getPopup, r=kmag
authorBob Silverberg <bsilverberg@mozilla.com>
Tue, 02 May 2017 14:55:03 -0400
changeset 356543 a646b729971e172877b2be0b677fca525d2c97a4
parent 356542 4adda7225b8557ed43aef5fce5fe7e7492f01835
child 356544 6562fdb4b99b2eccd5f0485e97e0a6acc97252c5
push id31767
push usercbook@mozilla.com
push dateFri, 05 May 2017 13:15:58 +0000
treeherdermozilla-central@8872ad4d52b6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskmag
bugs1361463
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1361463 - Fix typo in BrowserAction.getPopup, r=kmag The if statement in getPopup should read `if (!blockParser)` not `if (!this.blockParser)`. MozReview-Commit-ID: IBtHHS634sG
browser/components/extensions/ext-browserAction.js
--- a/browser/components/extensions/ext-browserAction.js
+++ b/browser/components/extensions/ext-browserAction.js
@@ -316,17 +316,17 @@ this.browserAction = class extends Exten
    */
   getPopup(window, popupURL, blockParser = false) {
     this.clearPopupTimeout();
     let {pendingPopup} = this;
     this.pendingPopup = null;
 
     if (pendingPopup) {
       if (pendingPopup.window === window && pendingPopup.popupURL === popupURL) {
-        if (!this.blockParser) {
+        if (!blockParser) {
           pendingPopup.unblockParser();
         }
 
         return pendingPopup;
       }
       pendingPopup.destroy();
     }