Bug 1470115 - Disable LifoAlloc memory protection on release builds. r=tcampbell
authorNicolas B. Pierron <nicolas.b.pierron@gmail.com>
Wed, 18 Jul 2018 17:36:18 +0000
changeset 427829 a6301149ad058f155139cecdfcf69195bb2c1f3a
parent 427828 7b42110e827beb8a59ec056708a02651177360a1
child 427830 ba9884ab1267e546a1a2fc6c653c4d5b095329b0
push id34318
push userccoroiu@mozilla.com
push dateMon, 23 Jul 2018 21:44:05 +0000
treeherdermozilla-central@fe48e26ca88c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstcampbell
bugs1470115
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1470115 - Disable LifoAlloc memory protection on release builds. r=tcampbell
js/src/ds/LifoAlloc.h
--- a/js/src/ds/LifoAlloc.h
+++ b/js/src/ds/LifoAlloc.h
@@ -219,17 +219,17 @@ class BumpChunk : public SingleLinkedLis
     uint8_t* const capacity_;
 
 #ifdef MOZ_DIAGNOSTIC_ASSERT_ENABLED
     // Magic number used to check against poisoned values.
     const uintptr_t magic_ : 24;
     static constexpr uintptr_t magicNumber = uintptr_t(0x4c6966);
 #endif
 
-#if defined(DEBUG) || defined(MOZ_DIAGNOSTIC_ASSERT_ENABLED)
+#if defined(DEBUG) || defined(MOZ_ASAN)
 # define LIFO_CHUNK_PROTECT 1
 #endif
 
 #ifdef LIFO_CHUNK_PROTECT
     // Constant used to know if the current chunk should be protected. This is
     // mainly use to prevent dead-lock in the MemoryProtectionExceptionHandler
     // methods.
     const uintptr_t protect_ : 1;