Bug 1546042 - Fix contrast of advanced panel in about:neterror in dark mode. r=johannh
authorTim Nguyen <ntim.bugs@gmail.com>
Thu, 25 Apr 2019 16:27:34 +0000
changeset 471332 a5b40abdd0650e724b1dedd55e231778065af2ac
parent 471331 f4002576fa1684fb028432840e6b39ae6a94ca5a
child 471333 cde301c4dbfc2fe7e5816331952075aa2a7989dd
push id35915
push useropoprus@mozilla.com
push dateThu, 25 Apr 2019 22:08:17 +0000
treeherdermozilla-central@7e40e33da3da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjohannh
bugs1546042
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1546042 - Fix contrast of advanced panel in about:neterror in dark mode. r=johannh Differential Revision: https://phabricator.services.mozilla.com/D28448
browser/themes/shared/aboutNetError.css
--- a/browser/themes/shared/aboutNetError.css
+++ b/browser/themes/shared/aboutNetError.css
@@ -1,18 +1,14 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 @import url("chrome://browser/skin/error-pages.css");
 
-:root {
-  --exception-button-container-background: #F5F5F7;
-}
-
 body.certerror {
   width: 100%;
   justify-content: normal;
 }
 
 body.caution {
   border-style: solid;
   border-color: #ffe900;
@@ -59,17 +55,17 @@ button:disabled {
   display: none;
 }
 
 #certErrorAndCaptivePortalButtonContainer {
   display: none;
 }
 
 #advancedPanelButtonContainer {
-  background-color: var(--exception-button-container-background);
+  background-color: rgba(128, 128, 147, 0.1);
   display: flex;
   justify-content: end;
   padding: 5px;
   margin-top: 2em;
 }
 
 body:not(.neterror) #certErrorAndCaptivePortalButtonContainer {
   display: flex;
@@ -119,18 +115,18 @@ body:not(.neterror) #advancedButton {
 #advancedPanelContainer {
   width: 100%;
   left: 0;
 }
 
 .advanced-panel {
   /* Hidden until the link is clicked */
   display: none;
-  background-color: white;
-  border: 1px lightgray solid;
+  background-color: var(--in-content-box-background);
+  border: 1px solid var(--in-content-box-border-color);
   margin: 48px auto;
   min-width: var(--in-content-container-min-width);
   max-width: var(--in-content-container-max-width);
 }
 
 #overrideWeakCryptoPanel {
   display: none;
   flex-direction: row;
@@ -195,17 +191,16 @@ body:not(.neterror) #advancedButton {
 }
 
 #cert_domain_link:not([href]) {
   color: var(--in-content-page-color);
   text-decoration: none;
 }
 
 .exceptionDialogButtonContainer {
-  background-color: var(--exception-button-container-background);
   display: flex;
   justify-content: end;
 }
 
 .exceptionDialogButtonContainer[hidden] {
   display: none;
 }