Bug 1258452 - Explicitly request READ_EXTERNAL_STORAGE permission. r=sebastian
authorNick Alexander <nalexander@mozilla.com>
Mon, 14 Mar 2016 14:23:56 -0700
changeset 289587 a42ef90399bd6a848fb839647ea328e9453ffe5f
parent 289586 91736cfdc9b0128cf40a779163d3fa244dcac933
child 289588 64a06fbc559d953d09d2681114b5e5ec6495416a
push id30107
push usercbook@mozilla.com
push dateTue, 22 Mar 2016 10:00:23 +0000
treeherdermozilla-central@3587b25bae30 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian
bugs1258452
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1258452 - Explicitly request READ_EXTERNAL_STORAGE permission. r=sebastian This permission was added in API 16, and is only enforced in API 19+. (It's benign to add it to APKs installed on API 15.) We want to declare it explicitly so that the bouncer APK and the main APK have the same permission set. There appears to be some fanciness with Gradle's implied permission system where the bouncer APK does not request READ implicitly where-as the main APK does request READ implicitly. This just makes things explicit (and uniform). MozReview-Commit-ID: LBblAPa0duV
mobile/android/base/FennecManifest_permissions.xml.in
--- a/mobile/android/base/FennecManifest_permissions.xml.in
+++ b/mobile/android/base/FennecManifest_permissions.xml.in
@@ -24,16 +24,20 @@
 
     <uses-permission android:name="@ANDROID_PACKAGE_NAME@.permission.PER_ANDROID_PACKAGE" />
 
     <uses-permission android:name="android.permission.CHANGE_WIFI_STATE"/>
     <uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>
     <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
     <uses-permission android:name="android.permission.INTERNET"/>
+    <!-- READ_EXTERNAL_STORAGE was added in API 16, and is only enforced in API
+         19+.  We declare it so that the bouncer APK and the main APK have the
+         same set of permissions. -->
+    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
     <uses-permission android:name="com.android.launcher.permission.INSTALL_SHORTCUT"/>
     <uses-permission android:name="com.android.launcher.permission.UNINSTALL_SHORTCUT"/>
     <uses-permission android:name="com.android.browser.permission.READ_HISTORY_BOOKMARKS"/>
 
     <uses-permission android:name="android.permission.WAKE_LOCK"/>
     <uses-permission android:name="android.permission.VIBRATE"/>
 #ifdef MOZ_ANDROID_DOWNLOADS_INTEGRATION