Bug 1540172 - Align close button at top for expressions r=nchevobbe
authorDavid Walsh <dwalsh@mozilla.com>
Tue, 02 Apr 2019 06:16:25 +0000
changeset 467520 a40b4bb80055362a0b874fc2b9f232110f5c7ec8
parent 467519 31c1b09faec49bde81d6cb798f930e95b70f6141
child 467521 a0a1f6c8e4d1e293e79b958d53b600f0ed51b58a
push id35802
push usercbrindusan@mozilla.com
push dateTue, 02 Apr 2019 15:46:39 +0000
treeherdermozilla-central@2eb225d3082f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnchevobbe
bugs1540172
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1540172 - Align close button at top for expressions r=nchevobbe Corrects the vertical alignment of the close button for watch expressions. Differential Revision: https://phabricator.services.mozilla.com/D25465
devtools/client/debugger/new/src/components/SecondaryPanes/Expressions.css
--- a/devtools/client/debugger/new/src/components/SecondaryPanes/Expressions.css
+++ b/devtools/client/debugger/new/src/components/SecondaryPanes/Expressions.css
@@ -96,17 +96,17 @@
 .expression-container__close-btn {
   position: absolute;
   /* hiding button outside of row until hovered or focused */
   top: -100px;
 }
 
 .expression-container:hover .expression-container__close-btn,
 .expression-container__close-btn:focus-within {
-  top: calc(50% - 8px);
+  top: 0;
 }
 
 [dir="ltr"] .expression-container__close-btn {
   right: 0;
 }
 
 [dir="rtl"] .expression-container__close-btn {
   left: 0;