Bug 1732328 - Remove the vestiges of LayerScope. r=gfx-reviewers,jrmuizel
authorTetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com>
Sat, 25 Sep 2021 16:22:25 +0000
changeset 593158 a3f0791a87fd3d2419768eff6da663361c9a3171
parent 593157 2008fb8bec214b47734b3401c211ea598a4a597a
child 593159 4f7e9fe53b44e13edc2813523abefcb0b75e01f0
push id38823
push userabutkovits@mozilla.com
push dateSat, 25 Sep 2021 21:37:43 +0000
treeherdermozilla-central@a3f0791a87fd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgfx-reviewers, jrmuizel
bugs1732328
milestone94.0a1
first release with
nightly linux32
a3f0791a87fd / 94.0a1 / 20210925213743 / files
nightly linux64
a3f0791a87fd / 94.0a1 / 20210925213743 / files
nightly mac
a3f0791a87fd / 94.0a1 / 20210925213743 / files
nightly win32
a3f0791a87fd / 94.0a1 / 20210925213743 / files
nightly win64
a3f0791a87fd / 94.0a1 / 20210925213743 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1732328 - Remove the vestiges of LayerScope. r=gfx-reviewers,jrmuizel `Layer::GetDisplayListLog()` also still contains the metion to LayerScope to dump display list. But this change does not remove it because it's a part of debugging display list. If we remove it, I think we should open a new bug for it. Differential Revision: https://phabricator.services.mozilla.com/D126512
build/clang-plugin/ThreadAllows.txt
build/win32/orderfile.txt
build/win64/orderfile.txt
toolkit/components/protobuf/regenerate_cpp_files.sh
--- a/build/clang-plugin/ThreadAllows.txt
+++ b/build/clang-plugin/ThreadAllows.txt
@@ -36,17 +36,16 @@ GraphRunner
 HTML5 Parser
 ICS parser
 IMAP
 IPC Launch
 IPDL Background
 IdentityCrypto
 ImageBridgeChld
 LS Thread
-LayerScope
 MDCDMThread
 MWQThread
 MediaCache
 MediaTelemetry
 MediaTrackGrph
 mtransport
 NamedPipeSrv
 Netlink Monitor
--- a/build/win32/orderfile.txt
+++ b/build/win32/orderfile.txt
@@ -12567,17 +12567,16 @@ skcms_TransferFunction_invert
 ?UpdatedInternal@BufferTextureHost@layers@mozilla@@MAEXPBV?$IntRegionTyped@UUnknownUnits@gfx@mozilla@@@gfx@3@@Z
 ?NeedsYFlip@TextureHost@layers@mozilla@@UBE_NXZ
 ?ComputeRGBStride@ImageDataSerializer@layers@mozilla@@YAHW4SurfaceFormat@gfx@3@H@Z
 ?CreateWrappingDataSourceSurface@Factory@gfx@mozilla@@SA?AU?$already_AddRefed@VDataSourceSurface@gfx@mozilla@@@@PAEHABU?$IntSizeTyped@UUnknownUnits@gfx@mozilla@@@23@W4SurfaceFormat@23@P6AXPAX@Z3@Z
 ?InitWrappingData@SourceSurfaceRawData@gfx@mozilla@@AAEXPAEABU?$IntSizeTyped@UUnknownUnits@gfx@mozilla@@@23@HW4SurfaceFormat@23@P6AXPAX@Z3@Z
 ?Release@?$AtomicRefCountedWithFinalize@VTextureHost@layers@mozilla@@@mozilla@@AAEXXZ
 ?SetCompositorAnimations@Layer@layers@mozilla@@QAEXABULayersId@23@ABVCompositorAnimations@23@@Z
 ?SetCompositorAnimations@AnimationInfo@layers@mozilla@@QAEXABULayersId@23@ABVCompositorAnimations@23@@Z
-?ContentChanged@LayerScope@layers@mozilla@@SAXPAVTextureHost@23@@Z
 ?AddBlendModeEffect@LayerComposite@layers@mozilla@@QAEXAAUEffectChain@23@@Z
 ?SendPendingAsyncMessages@HostIPCAllocator@layers@mozilla@@UAEXXZ
 ?OnMessageReceived@PCompositorBridgeParent@layers@mozilla@@UAE?AW4Result@HasResultCodes@ipc@3@ABVMessage@IPC@@AAPAV78@@Z
 ?ResumeComposition@CompositorBridgeParent@layers@mozilla@@QAEXXZ
 ?CancelCurrentCompositeTask@CompositorVsyncScheduler@layers@mozilla@@QAEXXZ
 ?ComputeRotation@AsyncCompositionManager@layers@mozilla@@QAEXXZ
 ?ComputeTransformForRotation@mozilla@@YA?AV?$BaseMatrix@M@gfx@1@ABU?$IntRectTyped@UUnknownUnits@gfx@mozilla@@@31@W4ScreenRotation@1@@Z
 ?TransformShadowTree@AsyncCompositionManager@layers@mozilla@@QAE_NABVSampleTime@23@V?$BaseTimeDuration@VTimeDurationValueCalculator@mozilla@@@3@W4TransformsToSkip@CompositorBridgeParentBase@23@@Z
@@ -12598,18 +12597,16 @@ skcms_TransferFunction_invert
 ??$ProjectRectBounds@M@?$Matrix4x4Typed@UParentLayerPixel@mozilla@@ULayerPixel@2@M@gfx@mozilla@@QBE?AU?$RectTyped@ULayerPixel@mozilla@@M@12@ABU?$RectTyped@UParentLayerPixel@mozilla@@M@12@ABU312@@Z
 ?Transform@nsRegion@@QAEAAV1@ABV?$Matrix4x4Typed@UUnknownUnits@gfx@mozilla@@U123@M@gfx@mozilla@@@Z
 ?GfxRectToIntRect@gfxUtils@@SA_NABU?$RectTyped@UUnknownUnits@gfx@mozilla@@N@gfx@mozilla@@PAU?$IntRectTyped@UUnknownUnits@gfx@mozilla@@@34@@Z
 ?IsOpaqueForVisibility@Layer@layers@mozilla@@QAE_NXZ
 ?Destroy@PaintedLayerComposite@layers@mozilla@@UAEXXZ
 ?GetFullyRenderedRegion@LayerComposite@layers@mozilla@@UAE?AV?$IntRegionTyped@UUnknownUnits@gfx@mozilla@@@gfx@3@XZ
 ??0CanvasLayerComposite@layers@mozilla@@QAE@PAVLayerManagerComposite@12@@Z
 ?RequestAllowFrameRecording@Compositor@layers@mozilla@@UAEX_N@Z
-?BeginFrame@LayerScopeAutoFrame@layers@mozilla@@CAX_J@Z
-?CheckSendable@LayerScope@layers@mozilla@@SA_NXZ
 ??$DrawGeometry@U?$RectTyped@UUnknownUnits@gfx@mozilla@@M@gfx@mozilla@@@BasicCompositor@layers@mozilla@@AAEXABU?$RectTyped@UUnknownUnits@gfx@mozilla@@M@gfx@2@0ABU?$IntRectTyped@UUnknownUnits@gfx@mozilla@@@42@ABUEffectChain@12@MABV?$Matrix4x4Typed@UUnknownUnits@gfx@mozilla@@U123@M@42@0_N@Z
 ?profiler_feature_active@@YA_NI@Z
 ?StartRemoteDrawingInRegion@CompositorWidget@widget@mozilla@@UAE?AU?$already_AddRefed@VDrawTarget@gfx@mozilla@@@@AAV?$IntRegionTyped@ULayoutDevicePixel@mozilla@@@gfx@3@PAW4BufferMode@layers@3@@Z
 ??0gfxWindowsSurface@@QAE@PAUHDC__@@I@Z
 _moz_cairo_win32_surface_create
 _cairo_win32_save_initial_clip
 ?GetDC@gfxWindowsSurface@@QAEPAUHDC__@@XZ
 _moz_cairo_win32_surface_get_height
@@ -12743,17 +12740,16 @@ skcms_TransferFunction_invert
 _cairo_traps_fini
 ?EndRemoteDrawingInRegion@CompositorWidget@widget@mozilla@@UAEXPAVDrawTarget@gfx@3@ABV?$IntRegionTyped@ULayoutDevicePixel@mozilla@@@53@@Z
 ?EnsureTransparentSurface@InProcessWinCompositorWidget@widget@mozilla@@QAE?AV?$RefPtr@VgfxASurface@@@@XZ
 ?SurfaceDestroyFunc@gfxASurface@@CAXPAX@Z
 ??1gfxASurface@@MAE@XZ
 ??1TextureSource@layers@mozilla@@UAE@XZ
 ?MaybeProcessQueue@ScreenshotGrabber@layers@mozilla@@QAEXXZ
 ?RecordCompositionPayloadsPresented@layers@mozilla@@YAXABV?$nsTArray@UCompositionPayload@layers@mozilla@@@@@Z
-?EndFrame@LayerScopeAutoFrame@layers@mozilla@@CAXXZ
 ?FlushPendingNotifyNotUsed@TextureSourceProvider@layers@mozilla@@QAEXXZ
 ?AlwaysScheduleComposite@LayerManagerComposite@layers@mozilla@@UBE_NXZ
 ?Reply_FlushRendering@PCompositorBridge@layers@mozilla@@YAPAVMessage@IPC@@H@Z
 ?RecordOnce@StartupTimeline@mozilla@@SAXW4Event@12@@Z
 ?DidPaintWindow@PresShell@mozilla@@QAEXXZ
 ?growStorageBy@?$Vector@_S$0A@VSystemAllocPolicy@js@@@mozilla@@AAE_NI@Z
 ?OnMessageReceived@PCompositorManagerChild@layers@mozilla@@UAE?AW4Result@HasResultCodes@ipc@3@ABVMessage@IPC@@@Z
 ?OnMessageReceived@PCompositorBridgeChild@layers@mozilla@@UAE?AW4Result@HasResultCodes@ipc@3@ABVMessage@IPC@@@Z
--- a/build/win64/orderfile.txt
+++ b/build/win64/orderfile.txt
@@ -12289,17 +12289,16 @@ skcms_TransferFunction_invert
 ??1?$nsTArray_Impl@UScrollMetadata@layers@mozilla@@UnsTArrayInfallibleAllocator@@@@QEAA@XZ
 ?ClearInvalidationStateBits@nsIFrame@@QEAAXXZ
 ?ClearInvalidations@LayerProperties@layers@mozilla@@SAXPEAVLayer@23@@Z
 ??$TransformPoint@M@?$Matrix4x4Typed@UScreenPixel@mozilla@@UParentLayerPixel@2@M@gfx@mozilla@@QEBA?AU?$Point4DTyped@UParentLayerPixel@mozilla@@M@12@AEBU?$Point4DTyped@UScreenPixel@mozilla@@M@12@@Z
 ?ClearInvalidRegion@Layer@layers@mozilla@@UEAAXXZ
 ?ClearInvalidRegion@PaintedLayer@layers@mozilla@@UEAAXXZ
 ?NotifySubDocInvalidation@nsPresContext@@SAXPEAVContainerLayer@layers@mozilla@@PEBV?$IntRegionTyped@UUnknownUnits@gfx@mozilla@@@gfx@4@@Z
 ?GetLastTransactionId@ClientLayerManager@layers@mozilla@@UEAA?AU?$BaseTransactionId@VTransactionIdType@layers@mozilla@@@23@XZ
-?EndFrame@LayerScopeAutoFrame@layers@mozilla@@CAXXZ
 ??$TransformAndClipBounds@M@?$Matrix4x4TypedFlagged@UUnknownUnits@gfx@mozilla@@U123@@gfx@mozilla@@QEBA?AU?$RectTyped@UUnknownUnits@gfx@mozilla@@M@12@AEBU312@0@Z
 ??_GColorLayerProperties@layers@mozilla@@UEAAPEAXI@Z
 ?NotifyInvalidation@nsPresContext@@QEAAXU?$BaseTransactionId@VTransactionIdType@layers@mozilla@@@layers@mozilla@@AEBU?$IntRectTyped@UUnknownUnits@gfx@mozilla@@@gfx@4@@Z
 ?NotifyInvalidation@nsPresContext@@QEAAXU?$BaseTransactionId@VTransactionIdType@layers@mozilla@@@layers@mozilla@@AEBUnsRect@@@Z
 ??_GFrameLayerBuilder@mozilla@@UEAAPEAXI@Z
 ??1FrameLayerBuilder@mozilla@@UEAA@XZ
 ??1LayerPropertiesBase@layers@mozilla@@UEAA@XZ
 ?EndPaint@PresShell@mozilla@@QEAAXXZ
@@ -12394,17 +12393,16 @@ skcms_TransferFunction_invert
 ?SetCompositorAnimations@AnimationInfo@layers@mozilla@@QEAAXAEBULayersId@23@AEBVCompositorAnimations@23@@Z
 ??0JSActor@dom@mozilla@@QEAA@PEAVnsISupports@@@Z
 ?WrapObject@JSWindowActorChild@dom@mozilla@@UEAAPEAVJSObject@@PEAUJSContext@@V?$Handle@PEAVJSObject@@@JS@@@Z
 ?Wrap@JSWindowActorChild_Binding@dom@mozilla@@YA_NPEAUJSContext@@PEAVJSWindowActorChild@23@PEAVnsWrapperCache@@V?$Handle@PEAVJSObject@@@JS@@V?$MutableHandle@PEAVJSObject@@@8@@Z
 ?QueryInterface@JSWindowActorChild@dom@mozilla@@UEAA?AW4nsresult@@AEBUnsID@@PEAPEAX@Z
 ?Init@JSWindowActorChild@dom@mozilla@@QEAAXAEBV?$nsTSubstring@D@@PEAVWindowGlobalChild@23@@Z
 ??0MozJSActorCallbacks@dom@mozilla@@QEAA@XZ
 ?Init@MozJSActorCallbacks@dom@mozilla@@QEAA_NAEAVBindingCallContext@23@V?$Handle@VValue@JS@@@JS@@PEBD_N@Z
-?ContentChanged@LayerScope@layers@mozilla@@SAXPEAVTextureHost@23@@Z
 ?SetRoot@BasicLayerManager@layers@mozilla@@UEAAXPEAVLayer@23@@Z
 ?AddBlendModeEffect@LayerComposite@layers@mozilla@@QEAAXAEAUEffectChain@23@@Z
 ?Name@EffectNV12@layers@mozilla@@UEAAPEBDXZ
 ?SendPendingAsyncMessages@HostIPCAllocator@layers@mozilla@@UEAAXXZ
 ??$InflateUTF8CharsToBufferAndTerminate@_SVUTF8Chars@JS@@@@YAXVUTF8Chars@JS@@PEA_S_KW4SmallestEncoding@1@@Z
 ?GetCallableProperty@CallbackInterface@dom@mozilla@@IEAA_NAEAVBindingCallContext@23@V?$Handle@UPropertyKey@JS@@@JS@@V?$MutableHandle@VValue@JS@@@6@@Z
 ?GetProtoObjectHandle@Event_Binding@dom@mozilla@@YA?AV?$Handle@PEAVJSObject@@@JS@@PEAUJSContext@@@Z
 ?WrapObject@WindowGlobalChild@dom@mozilla@@UEAAPEAVJSObject@@PEAUJSContext@@V?$Handle@PEAVJSObject@@@JS@@@Z
@@ -12629,18 +12627,16 @@ encoding_is_ascii_compatible
 ?Invert@?$Matrix4x4Typed@UUnknownUnits@gfx@mozilla@@U123@M@gfx@mozilla@@QEAA_NXZ
 ?Transform@nsRegion@@QEAAAEAV1@AEBV?$Matrix4x4Typed@UUnknownUnits@gfx@mozilla@@U123@M@gfx@mozilla@@@Z
 ?GfxRectToIntRect@gfxUtils@@SA_NAEBU?$RectTyped@UUnknownUnits@gfx@mozilla@@N@gfx@mozilla@@PEAU?$IntRectTyped@UUnknownUnits@gfx@mozilla@@@34@@Z
 ?IsOpaqueForVisibility@Layer@layers@mozilla@@QEAA_NXZ
 ?Destroy@PaintedLayerComposite@layers@mozilla@@UEAAXXZ
 ?GetFullyRenderedRegion@LayerComposite@layers@mozilla@@UEAA?AV?$IntRegionTyped@UUnknownUnits@gfx@mozilla@@@gfx@3@XZ
 ??0CanvasLayerComposite@layers@mozilla@@QEAA@PEAVLayerManagerComposite@12@@Z
 ?RequestAllowFrameRecording@Compositor@layers@mozilla@@UEAAX_N@Z
-?BeginFrame@LayerScopeAutoFrame@layers@mozilla@@CAX_J@Z
-?CheckSendable@LayerScope@layers@mozilla@@SA_NXZ
 ??$DrawGeometry@U?$RectTyped@UUnknownUnits@gfx@mozilla@@M@gfx@mozilla@@@BasicCompositor@layers@mozilla@@AEAAXAEBU?$RectTyped@UUnknownUnits@gfx@mozilla@@M@gfx@2@0AEBU?$IntRectTyped@UUnknownUnits@gfx@mozilla@@@42@AEBUEffectChain@12@MAEBV?$Matrix4x4Typed@UUnknownUnits@gfx@mozilla@@U123@M@42@0_N@Z
 ?profiler_feature_active@@YA_NI@Z
 ?GetSrcTileRect@TextureImage@gl@mozilla@@MEAA?AU?$IntRectTyped@UUnknownUnits@gfx@mozilla@@@gfx@3@XZ
 ?RFindLineContaining@nsLineBox@@SA_NPEAVnsIFrame@@AEBVnsLineList_iterator@@AEAV3@0PEAH@Z
 ??0gfxWindowsSurface@@QEAA@PEAUHDC__@@I@Z
 moz_cairo_win32_surface_create
 cairo_win32_save_initial_clip
 ?GetDC@gfxWindowsSurface@@QEAAPEAUHDC__@@XZ
--- a/toolkit/components/protobuf/regenerate_cpp_files.sh
+++ b/toolkit/components/protobuf/regenerate_cpp_files.sh
@@ -17,14 +17,13 @@ regenerate() {
     pushd "$DIR" >/dev/null
     protoc --cpp_out=. "$PROTO"
     popd >/dev/null
 }
 
 cd $(dirname $0)
 cd ../../.. # Top level.
 
-regenerate gfx/layers/protobuf/ LayerScopePacket.proto
 regenerate devtools/shared/heapsnapshot/ CoreDump.proto
 regenerate toolkit/components/reputationservice/chromium/chrome/common/safe_browsing/ csd.proto
 regenerate toolkit/components/url-classifier/chromium/ safebrowsing.proto
 command cp third_party/rust/viaduct/src/fetch_msg_types.proto toolkit/components/viaduct/fetch_msg_types.proto
 regenerate toolkit/components/viaduct/ fetch_msg_types.proto