Fix for bug 734506 (Fix DOM list binding generation - fix bad argument throwing). r=jst.
authorPeter Van der Beken <peterv@propagandism.org>
Fri, 14 Oct 2011 23:52:31 +0200
changeset 88799 a3b40d32ad975ba75def58e7c46aae23bcd2eccc
parent 88798 0d866eb9ac2438f2262911ae19c0f202a31a2de9
child 88800 790be8926d50d8869195e8c55c761f46b73607a1
push id22223
push usermbrubeck@mozilla.com
push dateMon, 12 Mar 2012 20:31:41 +0000
treeherdermozilla-central@406113c400a9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjst
bugs734506
milestone13.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Fix for bug 734506 (Fix DOM list binding generation - fix bad argument throwing). r=jst.
js/xpconnect/src/codegen.py
--- a/js/xpconnect/src/codegen.py
+++ b/js/xpconnect/src/codegen.py
@@ -264,17 +264,17 @@ def writeArgumentUnboxing(f, i, name, ty
                     % (type.name, argVal, name, name, argPtr))
             f.write("    if (NS_FAILED(rv)) {\n")
             if isSetter:
                 f.write("        xpc_qsThrowBadSetterValue("
                         "cx, rv, JSVAL_TO_OBJECT(*tvr.jsval_addr()), id);\n")
             elif haveCcx:
                 f.write("        xpc_qsThrowBadArgWithCcx(ccx, rv, %d);\n" % i)
             else:
-                f.write("        xpc_qsThrowBadArg(cx, rv, vp, %d);\n" % i)
+                f.write("        xpc_qsThrowBadArgWithDetails(cx, rv, %d, %s, %s);\n" % (i, "\"\"", "\"\""))
             f.write("        return JS_FALSE;\n"
                     "    }\n")
             return True
 
     warn("Unable to unbox argument of type %s (native type %s)" % (type.name, typeName))
     if i is None:
         src = '*vp'
     else: