Bug 1551916 - Flip column numbers back to being counts of code points and not code units. r=arai
authorJeff Walden <jwalden@mit.edu>
Tue, 21 May 2019 16:31:51 +0000
changeset 474775 a25b553e6824a80e7ddc42926d67048f1edf7e85
parent 474774 1a57fadeb896c57dcea6fd4812b97510811d4754
child 474776 c6ab5b9a7c0743eafc9573871f60f7299d6832d5
push id36046
push useraiakab@mozilla.com
push dateTue, 21 May 2019 21:45:52 +0000
treeherdermozilla-central@257f2c96cef5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersarai
bugs1551916
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1551916 - Flip column numbers back to being counts of code points and not code units. r=arai Differential Revision: https://phabricator.services.mozilla.com/D31304
js/src/frontend/TokenStream.h
--- a/js/src/frontend/TokenStream.h
+++ b/js/src/frontend/TokenStream.h
@@ -321,17 +321,17 @@ class MOZ_STACK_CLASS TokenStreamPositio
 
 template <typename Unit>
 class SourceUnits;
 
 // Column numbers *ought* be in terms of counts of code points, but in the past
 // we counted code units.  Set this to 0 to keep returning counts of code units
 // (even for UTF-8, which is clearly wrong, but we don't ship UTF-8 yet so this
 // is fine until we can fix users that depend on code-unit counting).
-#define JS_COLUMN_DIMENSION_IS_CODE_POINTS() 0
+#define JS_COLUMN_DIMENSION_IS_CODE_POINTS() 1
 
 class TokenStreamAnyChars : public TokenStreamShared {
  public:
   TokenStreamAnyChars(JSContext* cx, const JS::ReadOnlyCompileOptions& options,
                       StrictModeGetter* smg);
 
   template <typename Unit, class AnyCharsAccess>
   friend class GeneralTokenStreamChars;