Bug 1639108: Use the end offset for e10s IAccessibleText::newText instead of the length. r=eeejay
authorJames Teh <jteh@mozilla.com>
Tue, 19 May 2020 16:30:20 +0000
changeset 530928 a23749aac83b61459a2ec0ef6bcdf6be396dc7b4
parent 530927 80ded95f5d330ede6f09975c0fee20339c022e90
child 530929 bd3a170fc984a92ff6478480b16e3d8ce9cb2f68
push id37434
push userabutkovits@mozilla.com
push dateWed, 20 May 2020 10:05:10 +0000
treeherdermozilla-central@005ef1c25992 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerseeejay
bugs1639108
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1639108: Use the end offset for e10s IAccessibleText::newText instead of the length. r=eeejay Previously, we were incorrectly using the length. Differential Revision: https://phabricator.services.mozilla.com/D75897
accessible/windows/msaa/AccessibleWrap.cpp
--- a/accessible/windows/msaa/AccessibleWrap.cpp
+++ b/accessible/windows/msaa/AccessibleWrap.cpp
@@ -1760,17 +1760,17 @@ bool AccessibleWrap::DispatchTextChangeT
 
   HandlerControllerData& controller = sHandlerControllers->ElementAt(ctrlIndex);
   MOZ_ASSERT(controller.mPid);
   MOZ_ASSERT(controller.mCtrl);
 
   VARIANT_BOOL isInsert = aIsInsert ? VARIANT_TRUE : VARIANT_FALSE;
 
   IA2TextSegment textSegment{::SysAllocStringLen(aText.get(), aText.Length()),
-                             aStart, static_cast<long>(aLen)};
+                             aStart, aStart + static_cast<long>(aLen)};
 
   ASYNC_INVOKER_FOR(IHandlerControl)
   invoker(controller.mCtrl, Some(controller.mIsProxy));
 
   HRESULT hr = ASYNC_INVOKE(invoker, OnTextChange, PtrToLong(hwnd), msaaId,
                             isInsert, &textSegment);
 
   ::SysFreeString(textSegment.text);