Bug 1499222 - fix typo of node.listChild in extensions.js, fixing sorting of addons in addon manager. r=kmag
authoraceman <acelists@atlas.sk>
Mon, 15 Oct 2018 15:39:00 +0300
changeset 441563 a230ab0deaba1e1940b141c74278eb563b48e0cf
parent 441562 12a1714386d4428690a48ac0d0856fee1aa9f31e
child 441564 ce783284cca7bb33684bf6fbf197387afcd2c3b4
push id34868
push userncsoregi@mozilla.com
push dateWed, 17 Oct 2018 10:03:13 +0000
treeherdermozilla-central@99c45aca2d8a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskmag
bugs1499222
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1499222 - fix typo of node.listChild in extensions.js, fixing sorting of addons in addon manager. r=kmag
toolkit/mozapps/extensions/content/extensions.js
--- a/toolkit/mozapps/extensions/content/extensions.js
+++ b/toolkit/mozapps/extensions/content/extensions.js
@@ -1636,18 +1636,18 @@ function sortElements(aElements, aSortBy
 
   });
 }
 
 function sortList(aList, aSortBy, aAscending) {
   var elements = Array.slice(aList.childNodes, 0);
   sortElements(elements, [aSortBy], aAscending);
 
-  while (aList.listChild)
-    aList.removeChild(aList.lastChild);
+  while (aList.lastChild)
+    aList.lastChild.remove();
 
   for (let element of elements)
     aList.appendChild(element);
 }
 
 async function getAddonsAndInstalls(aType, aCallback) {
   let addons = null, installs = null;
   let types = (aType != null) ? [aType] : null;